Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://orion.fedorapeople.org/ansible-collection-ansible-mariadb.spec SRPM URL: https://orion.fedorapeople.org/ansible-collection-ansible-mariadb-6.0.2-1.fc46.src.rpm Description: MariaDB collection for Ansible. This collection was cloned from the ansible.mysql collection to allow its contributors and maintainers to focus on MariaDB-related automation development. MySQL is NOT supported by the ansible.mariadb collection! Fedora Account System Username: orion
Hi Orion, reviewed the package: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Python Software Foundation License 2.0", "*No copyright* BSD 2-Clause License", "GNU General Public License, Version 3", "GNU General Public License v3.0 or later", "*No copyright* GNU General Public License v3.0 or later". 201 files have unknown license. Detailed output of licensecheck in /home/andreas/FedoraReview/2521265-ansible-collection-ansible- mariadb/licensecheck.txt [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/ansible/collections/ansible_collections/ansible(ansible- collection-ansible-posix, ansible-collection-ansible-windows, ansible- collection-ansible-utils, ansible-collection-ansible-netcommon) [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 45158 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: ansible-collection-ansible-mariadb-6.0.2-1.fc46.noarch.rpm ansible-collection-ansible-mariadb-6.0.2-1.fc46.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpa3xzcr4n')] checks: 32, packages: 2 ansible-collection-ansible-mariadb.noarch: E: zero-length /usr/share/ansible/collections/ansible_collections/ansible/mariadb/changelogs/fragments/.keep ansible-collection-ansible-mariadb.src: E: spelling-error ('mysql', '%description -l en_US mysql -> MySQL') ansible-collection-ansible-mariadb.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/ansible/mariadb/.ansible-lint ansible-collection-ansible-mariadb.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/ansible/mariadb/changelogs/fragments/.keep ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/doc/ansible-collection-ansible-mariadb/CHANGELOG.rst /usr/share/ansible/collections/ansible_collections/ansible/mariadb/CHANGELOG.rst ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-ansible-mariadb/CONTRIBUTORS /usr/share/ansible/collections/ansible_collections/ansible/mariadb/CONTRIBUTORS ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-ansible-mariadb/COPYING /usr/share/ansible/collections/ansible_collections/ansible/mariadb/COPYING ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-ansible-mariadb/PSF-license.txt /usr/share/ansible/collections/ansible_collections/ansible/mariadb/PSF-license.txt ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/doc/ansible-collection-ansible-mariadb/README.md /usr/share/ansible/collections/ansible_collections/ansible/mariadb/README.md ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-ansible-mariadb/simplified_bsd.txt /usr/share/ansible/collections/ansible_collections/ansible/mariadb/simplified_bsd.txt 2 packages and 0 specfiles checked; 2 errors, 8 warnings, 7 filtered, 2 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.10.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 33, packages: 1 ansible-collection-ansible-mariadb.noarch: E: zero-length /usr/share/ansible/collections/ansible_collections/ansible/mariadb/changelogs/fragments/.keep ansible-collection-ansible-mariadb.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/ansible/mariadb/.ansible-lint ansible-collection-ansible-mariadb.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/ansible/mariadb/changelogs/fragments/.keep ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/doc/ansible-collection-ansible-mariadb/CHANGELOG.rst /usr/share/ansible/collections/ansible_collections/ansible/mariadb/CHANGELOG.rst ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-ansible-mariadb/CONTRIBUTORS /usr/share/ansible/collections/ansible_collections/ansible/mariadb/CONTRIBUTORS ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-ansible-mariadb/COPYING /usr/share/ansible/collections/ansible_collections/ansible/mariadb/COPYING ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-ansible-mariadb/PSF-license.txt /usr/share/ansible/collections/ansible_collections/ansible/mariadb/PSF-license.txt ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/doc/ansible-collection-ansible-mariadb/README.md /usr/share/ansible/collections/ansible_collections/ansible/mariadb/README.md ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-ansible-mariadb/simplified_bsd.txt /usr/share/ansible/collections/ansible_collections/ansible/mariadb/simplified_bsd.txt 1 packages and 0 specfiles checked; 1 errors, 8 warnings, 3 filtered, 1 badness; has taken 0.1 s 1. The duplicate file warnings for license stuff, etc. are "normal" Ansible module packages unfortunately. 2. The zero-length file /usr/share/ansible/collections/ansible_collections/ansible/mariadb/changelogs/fragments/.keep should be deleted 3. The spelling error "MySQL" is a false positive and can be ignored. The rest of the package looks good to me.
Spec URL: https://orion.fedorapeople.org/ansible-collection-ansible-mariadb.spec SRPM URL: https://orion.fedorapeople.org/ansible-collection-ansible-mariadb-6.0.2-1.fc46.src.rpm I've removed the empty file. I'll add an rpmlintrc file after import for the mysql spelling.
OK, rpmlint result looks like this now: Rpmlint ------- Checking: ansible-collection-ansible-mariadb-6.0.2-1.fc46.noarch.rpm ansible-collection-ansible-mariadb-6.0.2-1.fc46.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpc29zpmkp')] checks: 32, packages: 2 ansible-collection-ansible-mariadb.src: E: spelling-error ('mysql', '%description -l en_US mysql -> MySQL') ansible-collection-ansible-mariadb.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/ansible/mariadb/.ansible-lint ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/doc/ansible-collection-ansible-mariadb/CHANGELOG.rst /usr/share/ansible/collections/ansible_collections/ansible/mariadb/CHANGELOG.rst ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-ansible-mariadb/CONTRIBUTORS /usr/share/ansible/collections/ansible_collections/ansible/mariadb/CONTRIBUTORS ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-ansible-mariadb/COPYING /usr/share/ansible/collections/ansible_collections/ansible/mariadb/COPYING ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-ansible-mariadb/PSF-license.txt /usr/share/ansible/collections/ansible_collections/ansible/mariadb/PSF-license.txt ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/doc/ansible-collection-ansible-mariadb/README.md /usr/share/ansible/collections/ansible_collections/ansible/mariadb/README.md ansible-collection-ansible-mariadb.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-ansible-mariadb/simplified_bsd.txt /usr/share/ansible/collections/ansible_collections/ansible/mariadb/simplified_bsd.txt 2 packages and 0 specfiles checked; 1 errors, 7 warnings, 7 filtered, 1 badness; has taken 0.7 s Package builds and is installable. Haven't check functionality, though. Package is approved from my side.
The Pagure repository was created at https://src.fedoraproject.org/rpms/ansible-collection-ansible-mariadb Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
FEDORA-2026-903fef39ce (ansible-collection-ansible-mariadb-6.0.2-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-903fef39ce
FEDORA-EPEL-2026-2005b34897 (ansible-collection-ansible-mariadb-6.0.2-1.el10_4) has been submitted as an update to Fedora EPEL 10.4. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-2005b34897
Thanks for the review!
FEDORA-2026-903fef39ce (ansible-collection-ansible-mariadb-6.0.2-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2026-2005b34897 has been pushed to the Fedora EPEL 10.4 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-2005b34897 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2026-2005b34897 (ansible-collection-ansible-mariadb-6.0.2-1.el10_4) has been pushed to the Fedora EPEL 10.4 stable repository. If problem still persists, please make note of it in this bug report.