Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/sfaulken/transactional/fedora-rawhide-x86_64/10895217-read-only-root-fs/read-only-root-fs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sfaulken/transactional/fedora-rawhide-x86_64/10895217-read-only-root-fs/read-only-root-fs-1.0~git20260311.ea26e1b-2.fc46.src.rpm Description: Provides read only root setup for transactional style btrfs systems on Fedora FAS Username: sfaulken Reproducible: Always
Taking this review.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10897333 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2521657-read-only-root-fs/fedora-rawhide-x86_64/10897333-read-only-root-fs/fedora-review/review.txt Found issues: - Systemd service file(s) in read-only-root-fs Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Initial spec review: > %dnl BuildRequires: bootloader-rpm-macros? This can be dropped. > %package volatile This should be "%package -n dracut-volatile-overlay" instead, since that's the name of the dracut module. All the other dracut modules need to be correctly subpackaged too, and the dependencies for the modules needs to be correctly specified (if needed). > %autosetup -p1 -n %{name}-%{commit} Unless you plan to support EPEL 9 or older, this can be just "%autosetup -C -p1" > %post [...] > %posttrans [...] These scriptlets are dangerous and make too many assumptions. They need to be dropped and reworked entirely.