Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/sfaulken/transactional/fedora-rawhide-x86_64/10895290-txnupd-maintenance-tools/txnupd-maintenance-tools.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sfaulken/transactional/fedora-rawhide-x86_64/10895290-txnupd-maintenance-tools/txnupd-maintenance-tools-1.1.beta-1.fc46.src.rpm Description: Tools for maintenance of Transactional systems, including a D-Bus client/daemon for update notifications, provides a number of functions that didn't make sense to include in the dnf5-txnupd plugin. FAS Username: sfaulken Reproducible: Always
Taking this review.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10897336 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2521661-txnupd-maintenance-tools/fedora-rawhide-x86_64/10897336-txnupd-maintenance-tools/fedora-review/review.txt Found issues: - Systemd user unit service file(s) in txnupd-maintenance-tools Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Initial spec review: > Version: 1.1.beta This needs to be formulated "1.1~beta" otherwise 1.1 will sort lower than the betas. You might want your own custom version of the %version_no_tilde macro that handles your scheme for filenames and whatnot. > %autosetup -p1 Unless you plan to support EPEL 9 or older, this can be "%autosetup -C -p1", so that you don't have to deal with the name-version inconsistency once you fix Version.
Updated: SPEC URL: https://download.copr.fedorainfracloud.org/results/sfaulken/transactional/fedora-rawhide-x86_64/10915672-txnupd-maintenance-tools/txnupd-maintenance-tools.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sfaulken/transactional/fedora-rawhide-x86_64/10915672-txnupd-maintenance-tools/txnupd-maintenance-tools-1.1~beta-1.fc46.src.rpm