Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/sfaulken/transactional/fedora-rawhide-x86_64/10895357-grub2-snapper-plugin/grub2-snapper-plugin.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sfaulken/transactional/fedora-rawhide-x86_64/10895357-grub2-snapper-plugin/grub2-snapper-plugin-0.1.339f590-1.fc46.src.rpm Description: Provides snapper integration to grub2, allowing for selection and booting from btrfs snapshots FAS Username: sfaulken Reproducible: Always
Taking this review.
Initial spec review: > Version: 0.1.339f590 This version doesn't make sense. It doesn't follow any real version or Fedora's snapshot versioning scheme. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_complex_versioning > Source0: %{name}-%{version}.tar.zst This needs to be a SourceURL. > %autosetup -p1 Unless you plan to support EPEL 9 or older, this can be "%autosetup -C -p1", so that you don't have to deal with the name-version inconsistency once you fix Version. > %config(noreplace) %{_sysconfdir}/grub.d/80_suse_btrfs_snapshot I'm pretty sure this is a script and not configuration, so this shouldn't be declared as a config file. (Yes, I know it's in the wrong place for that... GRUB needs to fix that someday...)
SPEC URL: https://download.copr.fedorainfracloud.org/results/sfaulken/transactional/fedora-rawhide-x86_64/10951246-grub2-snapper-plugin/grub2-snapper-plugin.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sfaulken/transactional/fedora-rawhide-x86_64/10951246-grub2-snapper-plugin/grub2-snapper-plugin-2.14~20260904-1.fc46.src.rpm
Please note that i am not a fedora packager and this is a practice review do you have any specific reason to not use %autorelease and %autochangelog? https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_release_tag https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs