Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://ankursinha.fedorapeople.org/gnome-shell-extension-focus-timer/gnome-shell-extension-focus-timer.spec SRPM URL: https://ankursinha.fedorapeople.org/gnome-shell-extension-focus-timer/gnome-shell-extension-focus-timer-3-2.fc46.src.rpm Upstream URL: https://github.com/focustimerhq/gnome-shell-extension-focus-timer Description: Focus Timer is an app based on the Pomodoro Technique that helps you break work into intervals (typically 25 minutes), separated by short breaks. This builds focus and prevents burnout. Desktop Integration Features: - Top bar indicator to quickly start, pause, and control your timer - Notifications showing a live countdown of your session - Screen overlay active during breaks, designed to be easy to dismiss - Automatic Do-Not-Disturb mode to reduce interruptions while you focus - Lock screen widget to check your timer without having to unlock Fedora Account System Username: ankursinha
Copr build: https://copr.fedorainfracloud.org/coprs/build/10901170 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2523330-gnome-shell-extension-focus-timer/fedora-rawhide-x86_64/10901170-gnome-shell-extension-focus-timer/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> License: GPL-3.0-only The source files are marked with "SPDX-License-Identifier: GPL-3.0-or-later". > Source0: %forgesource The source URL returns "404 not found". > %global extension focus-timer > [...] > Requires: focus-timer > Provides: %{extension} = %{version}-%{release} Won't this make "dnf install focus-timer" prefer the extension over the base app? I'm also not sure if that'll properly pull in the base app. Also, fedora-review complains about /usr/share/glib-2.0 being unowned.
Thanks for the review. Updated spec/srpm: Spec URL: https://ankursinha.fedorapeople.org/gnome-shell-extension-focus-timer/gnome-shell-extension-focus-timer.spec SRPM URL: https://ankursinha.fedorapeople.org/gnome-shell-extension-focus-timer/gnome-shell-extension-focus-timer-3-3.fc46.src.rpm Changes: - update license - add missing glib2 requires - remove unnecessary provides
Also corrected the source url---had to define a "tag" global for forge macros to work correctly.
re/provides, I saw some packages use "Provides: gnome-shell-extension(%{uuid})". Maybe something worth considering. Anyway, LGTM. Approved. Package Review ============== Legend: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4648 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Spec file according to URL is the same as in SRPM. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: gnome-shell-extension-focus-timer-3-3.fc46.noarch.rpm gnome-shell-extension-focus-timer-3-3.fc46.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp8acj79lh')] checks: 32, packages: 2 gnome-shell-extension-focus-timer.spec: W: no-%check-section gnome-shell-extension-focus-timer.noarch: E: explicit-lib-dependency glib2 2 packages and 0 specfiles checked; 1 errors, 1 warnings, 7 filtered, 1 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.10.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 33, packages: 1 gnome-shell-extension-focus-timer.noarch: E: explicit-lib-dependency glib2 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 3 filtered, 1 badness; has taken 0.0 s Source checksums ---------------- https://github.com/focustimerhq/gnome-shell-extension-focus-timer/archive/3/gnome-shell-extension-focus-timer-3.tar.gz : CHECKSUM(SHA256) this package : 76e112e4cbea90e13da36dbd42baa32b97f4018d96a7e8cd2e8327ef6fac386a CHECKSUM(SHA256) upstream package : 76e112e4cbea90e13da36dbd42baa32b97f4018d96a7e8cd2e8327ef6fac386a Requires -------- gnome-shell-extension-focus-timer (rpmlib, GLIBC filtered): focus-timer glib2 gnome-shell Provides -------- gnome-shell-extension-focus-timer: gnome-shell-extension-focus-timer Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2523330 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Haskell, SugarActivity, Perl, C/C++, Ocaml, fonts, PHP, Python, Java, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-extension-focus-timer Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
Thanks very much for the review. Building + pushing updates now.