Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://ikkoku.de/python-pysequoia/python-pysequoia.spec SRPM URL: https://ikkoku.de/python-pysequoia/python-pysequoia-0.1.34%5e20260825.3d0bd657-1.fc44.src.rpm Description: This library provides OpenPGP facilities in Python through the Sequoia PGP library. If you need to work with encryption and digital signatures using an IETF standardized protocol, this package is for you! Fedora Account System Username: suraia The package is using a Git snapshot, because the latest released version (0.1.34) does not build on rawhide/f45.
Hi, sequoia-pgp maintainer here. Out of curiosity, what you're packaging this for? I'm packaging all (official) Sequoia-PGP libraries and tools, but this one wasn't on the list since it's an unofficial / third-party project (now). That said, at least one thing is missing from the package - taking into account statically linked Rust dependencies. So the "License: Apache-2.0" tag is incomplete. I recommend you take a look at other, similar packages (python-nh3, python-dulwich, python-pendulum, etc.) and the relevant package template in the Rust Packaging Guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_python_project
Copr build: https://copr.fedorainfracloud.org/coprs/build/10908923 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2524474-python-pysequoia/fedora-rawhide-x86_64/10908923-python-pysequoia/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi Fabio, thanks for the feedback! I'm packaging this for Gajim, which transitioned from a weak python3-gnupg dependency to a hard python3-pysequoia one (see https://dev.gajim.org/gajim/gajim). Thanks for the hint about the packaging guidelines. I used python-rignore for inspiration, but apparently missed the license part. I've updated the spec, so it should now hopefully be guideline-compliant: Spec URL: https://ikkoku.de/python-pysequoia/python-pysequoia.spec SRPM URL: https://ikkoku.de/python-pysequoia/python-pysequoia-0.1.34%5e20260825.3d0bd657-1.fc44.src.rpm
Created attachment 2155847 [details] The .spec file difference from Copr build 10908923 to 10912344
Copr build: https://copr.fedorainfracloud.org/coprs/build/10912344 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2524474-python-pysequoia/fedora-rawhide-x86_64/10912344-python-pysequoia/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Will get to this tomorrow.
Upstream has released version 0.1.35, so I have updated the package: Spec URL: https://ikkoku.de/python-pysequoia/python-pysequoia.spec SRPM URL: https://ikkoku.de/python-pysequoia/python-pysequoia-0.1.35-1.fc44.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* Apache License". 58 files have unknown license. Detailed output of licensecheck in /home/fedora- packaging/reviews/python-pysequoia/2524474-python- pysequoia/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.15, /usr/lib64/python3.15/site-packages [x]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 26858 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pysequoia-0.1.35-1.fc46.x86_64.rpm python-pysequoia-0.1.35-1.fc46.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpg073g_gg')] checks: 32, packages: 2 python-pysequoia.spec:37: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 37) 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 7 filtered, 0 badness; has taken 0.8 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.10.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 33, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0 badness; has taken 0.2 s Unversioned so-files -------------------- python3-pysequoia: /usr/lib64/python3.15/site-packages/pysequoia/pysequoia.cpython-315-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/wiktor-k/pysequoia/archive/refs/tags/v0.1.35.tar.gz#/python-pysequoia-0.1.35.tar.gz : CHECKSUM(SHA256) this package : 544d0992f52027f42238480e1f537d1fac45ea882f1f2c1b9bb88f04e4dcf503 CHECKSUM(SHA256) upstream package : 544d0992f52027f42238480e1f537d1fac45ea882f1f2c1b9bb88f04e4dcf503 Requires -------- python3-pysequoia (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libcrypto.so.4()(64bit) libcrypto.so.4(OPENSSL_4.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) python(abi) rtld(GNU_HASH) Provides -------- python3-pysequoia: python-pysequoia python3-pysequoia python3-pysequoia(x86-64) python3.15-pysequoia python3.15dist(pysequoia) python3dist(pysequoia) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2524474 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: Java, SugarActivity, Perl, Haskell, fonts, Ocaml, R, C/C++, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Sorry for the delay. b) Koji build https://koji.fedoraproject.org/koji/taskinfo?taskID=150323685 c) Consider changing the source field from Source0: https://github.com/wiktor-k/pysequoia/archive/refs/tags/v%{version}.tar.gz#/%{name}-%{version}.tar.gz to Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz d) Approved.
Agreed with comment c), the latter is the documented reference Source URL for GitHub tarballs: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags Please consider adding @rust-sig and / or me (decathorpe) as Sequoia-PGP maintainer as co-maintainer to the package after you have imported it. This helps us deal with doing package (re)builds for bug fixes or to apply fixes for security issues.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pysequoia Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
FEDORA-2026-ded673a4b8 (python-pysequoia-0.1.35-1.fc46) has been submitted as an update to Fedora 46. https://bodhi.fedoraproject.org/updates/FEDORA-2026-ded673a4b8
FEDORA-2026-ded673a4b8 (python-pysequoia-0.1.35-1.fc46) has been pushed to the Fedora 46 stable repository. If problem still persists, please make note of it in this bug report.