Bug 2527707 - Review Request: nodejs-oxc-parser - Fast JavaScript/TypeScript parser implemented in Rust
Summary: Review Request: nodejs-oxc-parser - Fast JavaScript/TypeScript parser impleme...
Keywords:
Status: RELEASE_PENDING
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tomas Hrcka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-09-02 19:05 UTC by Gordon Messmer
Modified: 2026-11-13 20:46 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
thrcka: fedora-review+


Attachments (Terms of Use)

Comment 2 Tomas Hrcka 2026-11-11 18:53:04 UTC
Package Review: nodejs-oxc-parser-0.156.0-1.fc46
================================================

Bug:       2527707 - Review Request: nodejs-oxc-parser - Fast JavaScript/TypeScript parser implemented in Rust
Bug URL:   https://bugzilla.redhat.com/show_bug.cgi?id=2527707
Reviewer:  Automated/assisted review (fedora-review 0.12.0)
Date:      2026-11-11
Status:    CHANGES REQUESTED

Builds and passes %check, but the SRPM was built from a stale spec: its License field is only 'MIT', while the package bundles many differently-licensed Rust crates and npm modules. The changelog also contains an rpmautospec 'Unknown User / Uncommitted changes' entry.

Issues:
=======
- [MUST] License field in the SRPM does not match the actual licenses (SRPM says MIT; bundled crates/npm modules are Apache-2.0, BSD, Unicode-3.0, MPL-2.0, ISC, Zlib, etc.). The URL spec has the correct expression; rebuild from it.
- [MUST] Changelog has an rpmautospec 'Unknown User / Uncommitted changes' entry.
- [SHOULD] Latest upstream is 0.158.0; 0.156.0 is packaged.
- [SHOULD] Spec URL vs SRPM diff is real for the License field (not only rpmautospec).

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

Generic:
[x]: Package does not contain kernel modules.
     Note: No kernel modules in the package file list.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
     Note: No libtool archives in the package file list.
[x]: Package contains no static executables.
     Note: No static executables; the native addon is a shared object.
[x]: Rpath absent or only used for internal libs.
     Note: No rpath entries found.
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: SRPM spec has 'License: MIT'. The URL spec has the correct
     compound expression (MIT AND Apache-2.0 AND BSD-3-Clause AND
     Unicode-3.0 AND ...), and licensecheck finds Apache-2.0, MPL-2.0, ISC,
     BSD, Unlicense, Zlib and others. Rebuild from the updated spec.
[!]: If the package is under multiple licenses, the licensing breakdown must
     be documented in the spec.
     Note: The URL spec documents the breakdown; the SRPM spec does not.
     LICENSE.dependencies and the bundled-licenses file are installed via
     %license.
[x]: %build honors applicable compiler flags or justifies otherwise.
     Note: Fedora CFLAGS/CXXFLAGS/RUSTFLAGS are present in build.log.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
     Note: Bundled npm modules are declared with Provides: bundled(...);
     vendored Rust crates are documented in LICENSE.dependencies.
[!]: Changelog in prescribed format.
     Note: The SRPM changelog contains an 'Unknown User <please-configure-
     git-user> - Uncommitted changes' entry. Commit the tree and
     rebuild.
[x]: Sources contain only permissible code or content.
     Note: The source archives contain upstream vendor/test fixtures, but no
     prebuilt binary is installed. The shipped .node addon is built from
     source and is loaded by %check.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
     Note: README/docs are not needed at runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
     Note: The spec consistently uses macros.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
     Note: rpm -qp --conflicts is empty.
[x]: Package obeys FHS, except libexecdir and /usr/target.
     Note: All installed paths are under /usr.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
     Note: Requires are auto-generated from ELF/JS metadata or explicitly
     justified in the spec.
[x]: Spec file is legible and written in American English.
     Note: rpmlint spelling warnings are technical terms (napi, vendored,
     bundler, minifier, tsconfig), not spec errors.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
     Note: debuginfo/debugsource subpackages were built.
[x]: Package is not known to require an ExcludeArch tag.
     Note: ExclusiveArch: %{nodejs_arches} is the Node.js guideline; the
     package was built on x86_64.
[!]: Package complies to the Packaging Guidelines
     Note: See the MUST failures listed in Issues.
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
     Note: The package installed into the buildroot; see the install log.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %license.
     Note: The %license files are present in the binary RPM.
[x]: The License field must be a valid SPDX expression.
     Note: license-validate accepts both 'MIT' (SRPM) and the URL spec's
     compound expression; the SRPM expression is valid but incomplete (see
     item 6).
[x]: Package requires other packages for directories it uses.
     Note: The package owns the node_modules directory it uses.
[x]: Package must own all directories that it creates.
     Note: The package owns the directories it creates.
[x]: Package does not own files or directories owned by other packages.
     Note: No file or directory conflicts with another package.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
     Note: Uses %{buildroot}.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: No rm -rf of the buildroot at the start of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
     Note: Summary/%description macros expand at SRPM build time.
[x]: Dist tag is present.
     Note: Dist tag is present.
[x]: Package does not contain duplicates in %files.
     Note: No duplicate %files entries.
[x]: Permissions on files are set properly.
     Note: File modes are standard (0644 files, 0755 native addon/CLI).
[x]: Package must not depend on deprecated() packages.
     Note: No deprecated dependencies found.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
     Note: %makeinstall is not used.
[x]: Package is named using only allowed ASCII characters.
     Note: Package name uses only ASCII characters.
[x]: Package does not use a name that already exists.
     Note: New package name; no existing Fedora package with this name.
[x]: Package is not relocatable.
     Note: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
     Note: fedora-review source checksum matches the upstream tarball.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
     Note: Spec file name matches %{name}.spec.
[x]: File names are valid UTF-8.
     Note: All filenames are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation is small and stays in the main package.
[x]: Packages must not store files under /srv, /opt or /usr/local
     Note: No files under /srv, /opt, or /usr/local.

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
     Note: Upstream ships its license text; no need to query upstream.
[x]: Final provides and requires are sane (see attachments).
     Note: Provides/Requires are sane.
[x]: Package functions as described.
     Note: %check loads and exercises the installed module.
[!]: Latest version is packaged.
     Note: Upstream npm latest is 0.158.0; the package is 0.156.0.
[x]: Package does not include license text files separate from upstream.
     Note: The upstream license text is included in %license.
[x]: SourceX tarball generation or download is documented.
     Note: Source generation/download is documented in the spec comments and
     sources script.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: Upstream does not publish signatures for these tarballs;
     gpgverify is not applicable.
[x]: %check is present and all tests pass.
     Note: %check passed during the mock build.
[x]: Packages should try to preserve timestamps of original installed files.
     Note: cp -p/-pr is used, preserving timestamps.
[x]: Reviewer should test that the package builds in mock.
     Note: Mock build succeeded on x86_64.
[x]: Buildroot is not present
     Note: No Buildroot tag.
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: No %clean section with rm -rf.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
     Note: No requires outside the standard system directories.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
     Note: No Packager/Vendor/PreReq/Copyright tags.
[x]: SourceX is a working URL.
     Note: The Source URLs are reachable.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
     Note: Build verified on x86_64; ExclusiveArch limits the supported set.
[x]: Spec use %global instead of %define unless justified.
     Note: %global is used; the rpmautospec-generated %define is acceptable.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: The diff is not only rpmautospec: it also changes License from
     the compound expression to 'MIT'. That part is a real issue.
[x]: Rpmlint is run on debuginfo package(s).
     Note: rpmlint on the debuginfo package is clean.
[x]: Rpmlint is run on all installed packages.
     Note: rpmlint on the installed packages ran; the messages are noted
     below.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Large data/noarch handling is fine.

Verification performed:
======================
- Mock build succeeded on fedora-rawhide-x86_64; build.log shows %build and %check ran.
- %check imports the installed ESM entry point and verifies that parseSync is a function; it passed.
- licensecheck.txt, LICENSE.dependencies and the bundled-licenses file were inspected. LICENSE.dependencies inside the binary RPM enumerates the exact crate licenses and matches the compound expression in the URL spec.
- rpm -qp --provides: npm(oxc-parser) and bundled(nodejs-@oxc-project/types) are present.
- rpm -qp --conflicts is empty.
- license-validate accepts both the SRPM 'MIT' and the URL spec's compound expression.
- No prebuilt .node file is shipped; the addon is built by napi/cargo and loaded by %check.


Attachments / generated data
=============================

Rpmlint
-------
Checking: nodejs-oxc-parser-0.156.0-1.fc46.x86_64.rpm
          nodejs-oxc-parser-0.156.0-1.fc46.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpk0m75no1')]
checks: 32, packages: 2

nodejs-oxc-parser.src: E: spelling-error ('napi', '%description -l en_US napi -> nap, nape, naps')
nodejs-oxc-parser.src: E: spelling-error ('vendored', '%description -l en_US vendored -> vendor ed, vendor-ed, vendor')
nodejs-oxc-parser.x86_64: E: spelling-error ('napi', '%description -l en_US napi -> nap, nape, naps')
nodejs-oxc-parser.x86_64: E: spelling-error ('vendored', '%description -l en_US vendored -> vendor ed, vendor-ed, vendor')
nodejs-oxc-parser.spec: W: invalid-url Source0: oxc-parser-0.156.0-stripped.tar.gz
nodejs-oxc-parser.spec: W: invalid-url Source1: oxc-parser-0.156.0-npm.tgz
nodejs-oxc-parser.spec: W: invalid-url Source2: oxc-parser-0.156.0-nm-prod.tgz
nodejs-oxc-parser.spec: W: invalid-url Source3: oxc-parser-0.156.0-nm-dev.tgz
nodejs-oxc-parser.spec: W: invalid-url Source5: oxc-parser-0.156.0-vendor.tar.xz
 2 packages and 0 specfiles checked; 4 errors, 5 warnings, 9 filtered, 4 badness; has taken 0.8 s 




Rpmlint (debuginfo)
-------------------
Checking: nodejs-oxc-parser-debuginfo-0.156.0-1.fc46.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpguqmqxtf')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.6 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.10.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 33, packages: 2

nodejs-oxc-parser.x86_64: W: spelling-error ('napi', '%description -l en_US napi -> nap, nape, naps')
nodejs-oxc-parser.x86_64: W: spelling-error ('vendored', '%description -l en_US vendored -> vendor ed, vendor-ed, vendor')
 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 10 filtered, 0 badness; has taken 0.1 s 



Requires
--------
nodejs-oxc-parser (rpmlib, GLIBC filtered):
    ld-linux-x86-64.so.2()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3)(64bit)
    libgcc_s.so.1(GCC_4.2.0)(64bit)
    libm.so.6()(64bit)
    nodejs(engine)
    nodejs24
    rtld(GNU_HASH)



Provides
--------
nodejs-oxc-parser:
    bundled(nodejs-@oxc-project/types)
    nodejs-oxc-parser
    nodejs-oxc-parser(x86-64)
    npm(oxc-parser)



Diff spec file in url and in SRPM
---------------------------------
--- /home/humaton/projects/fedora/fetch-bz-run-review/2527707-nodejs-oxc-parser/srpm/nodejs-oxc-parser.spec	2026-11-09 19:27:40.010381466 +0100
+++ /home/humaton/projects/fedora/fetch-bz-run-review/2527707-nodejs-oxc-parser/srpm-unpacked/nodejs-oxc-parser.spec	2026-10-27 01:00:00.000000000 +0100
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.8.4)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 # oxc-parser ships as an unscoped npm package (install path
 # %%{nodejs_sitelib}/oxc-parser).  The published npm package is pure JavaScript
@@ -19,5 +29,5 @@
 # and in oxc-parser-%%{version}-bundled-licenses.txt (the bundled npm build
 # dependency, @napi-rs/cli).
-License:        MIT AND ((Apache-2.0 OR MIT) AND BSD-3-Clause) AND ((MIT OR Apache-2.0) AND Unicode-3.0) AND (0BSD OR MIT OR Apache-2.0) AND (Apache-2.0 AND ISC) AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR GPL-2.0-only) AND (Apache-2.0 OR ISC OR MIT) AND (Apache-2.0 OR MIT) AND (Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT) AND (Apache-2.0 WITH LLVM-exception OR BSL-1.0) AND Apache-2.0 AND (BSD-2-Clause OR Apache-2.0 OR MIT) AND BSD-3-Clause AND CDLA-Permissive-2.0 AND ISC AND (MIT OR Apache-2.0 OR LGPL-2.1-or-later) AND (MIT OR Apache-2.0) AND (MIT OR Zlib OR Apache-2.0) AND MIT-0 AND MIT AND Unicode-3.0 AND (Unlicense OR MIT) AND Zlib
+License:        MIT
 URL:            https://oxc.rs
 # Two upstream inputs:
@@ -156,3 +166,9 @@
 
 %changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Tue Oct 27 2026 Unknown User <please-configure-git-user> - 0.156.0-1
+- Uncommitted changes
+
+* Wed Aug 19 2026 Gordon Messmer <gmessmer> - 0.127.0-1
+- Package oxc-parser, building the native binding from source
+## END: Generated by rpmautospec


Generated by fedora-review 0.12.0 (a08f0fc) last change: 2026-09-18
Command line :/usr/bin/fedora-review -B -b 2527707
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: R, SugarActivity, Java, Perl, PHP, fonts, Python, Haskell, Ocaml, Ruby
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH, UNRETIREMENT

Comment 4 Tomas Hrcka 2026-11-13 10:28:55 UTC
Package Review: nodejs-oxc-parser-0.158.0-1.fc46
================================================

Bug:       2527707 - Review Request: nodejs-oxc-parser - Fast JavaScript/TypeScript parser implemented in Rust
Bug URL:   https://bugzilla.redhat.com/show_bug.cgi?id=2527707
Reviewer:  Automated/assisted review (fedora-review 0.12.0)
Date:      2026-11-13
Status:    APPROVED

Builds and passes %check. The SRPM License is now the full compound expression, the changelog is properly attributed, and 0.158.0 is the current upstream release. No MUST or SHOULD problems remain.

Issues:
=======
- [INFO] Spec URL vs SRPM diff is rpmautospec-only (false positive).

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

Generic:
[x]: Package does not contain kernel modules.
     Note: No kernel modules in the package file list.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
     Note: No libtool archives in the package file list.
[x]: Package contains no static executables.
     Note: No static executables; the native addon is a shared object.
[x]: Rpath absent or only used for internal libs.
     Note: No rpath entries found.
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: SRPM License is the full compound expression and matches the
     crates listed in LICENSE.dependencies; license-validate accepts it.
[x]: If the package is under multiple licenses, the licensing breakdown must
     be documented in the spec.
     Note: The spec comments and LICENSE.dependencies document the
     breakdown.
[x]: %build honors applicable compiler flags or justifies otherwise.
     Note: Fedora CFLAGS/CXXFLAGS/RUSTFLAGS are present in build.log.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
     Note: Bundled npm modules are declared with Provides: bundled(...);
     vendored Rust crates are documented in LICENSE.dependencies.
[x]: Changelog in prescribed format.
     Note: Changelog is properly attributed; the previous 'Unknown User /
     Uncommitted changes' entry is gone.
[x]: Sources contain only permissible code or content.
     Note: The source archives contain upstream vendor/test fixtures, but no
     prebuilt binary is installed. The shipped .node addon is built from
     source and is loaded by %check.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
     Note: README/docs are not needed at runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
     Note: The spec consistently uses macros.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
     Note: rpm -qp --conflicts is empty.
[x]: Package obeys FHS, except libexecdir and /usr/target.
     Note: All installed paths are under /usr.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
     Note: Requires are auto-generated from ELF/JS metadata or explicitly
     justified in the spec.
[x]: Spec file is legible and written in American English.
     Note: rpmlint spelling warnings are technical terms (napi, vendored,
     bundler, minifier, tsconfig), not spec errors.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
     Note: debuginfo/debugsource subpackages were built.
[x]: Package is not known to require an ExcludeArch tag.
     Note: ExclusiveArch: %{nodejs_arches} is the Node.js guideline; the
     package was built on x86_64.
[x]: Package complies to the Packaging Guidelines
     Note: All MUST items pass; any remaining findings are SHOULD items.
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
     Note: The package installed into the buildroot; see the install log.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %license.
     Note: The %license files are present in the binary RPM.
[x]: The License field must be a valid SPDX expression.
     Note: license-validate accepts the expression.
[x]: Package requires other packages for directories it uses.
     Note: The package owns the node_modules directory it uses.
[x]: Package must own all directories that it creates.
     Note: The package owns the directories it creates.
[x]: Package does not own files or directories owned by other packages.
     Note: No file or directory conflicts with another package.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
     Note: Uses %{buildroot}.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: No rm -rf of the buildroot at the start of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
     Note: Summary/%description macros expand at SRPM build time.
[x]: Dist tag is present.
     Note: Dist tag is present.
[x]: Package does not contain duplicates in %files.
     Note: No duplicate %files entries.
[x]: Permissions on files are set properly.
     Note: File modes are standard (0644 files, 0755 native addon/CLI).
[x]: Package must not depend on deprecated() packages.
     Note: No deprecated dependencies found.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
     Note: %makeinstall is not used.
[x]: Package is named using only allowed ASCII characters.
     Note: Package name uses only ASCII characters.
[x]: Package does not use a name that already exists.
     Note: New package name; no existing Fedora package with this name.
[x]: Package is not relocatable.
     Note: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
     Note: fedora-review source checksum matches the upstream tarball.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
     Note: Spec file name matches %{name}.spec.
[x]: File names are valid UTF-8.
     Note: All filenames are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation is small and stays in the main package.
[x]: Packages must not store files under /srv, /opt or /usr/local
     Note: No files under /srv, /opt, or /usr/local.

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
     Note: Upstream ships its license text; no need to query upstream.
[x]: Final provides and requires are sane (see attachments).
     Note: Provides/Requires are sane.
[x]: Package functions as described.
     Note: %check loads and exercises the installed module.
[x]: Latest version is packaged.
     Note: Upstream npm latest is 0.158.0, matching the package.
[x]: Package does not include license text files separate from upstream.
     Note: The upstream license text is included in %license.
[x]: SourceX tarball generation or download is documented.
     Note: Source generation/download is documented in the spec comments and
     sources script.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: Upstream does not publish signatures for these tarballs;
     gpgverify is not applicable.
[x]: %check is present and all tests pass.
     Note: %check imports the installed ESM entry point and verifies that
     parseSync is a function; it passed.
[x]: Packages should try to preserve timestamps of original installed files.
     Note: cp -p/-pr is used, preserving timestamps.
[x]: Reviewer should test that the package builds in mock.
     Note: Mock build succeeded on x86_64.
[x]: Buildroot is not present
     Note: No Buildroot tag.
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: No %clean section with rm -rf.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
     Note: No requires outside the standard system directories.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
     Note: No Packager/Vendor/PreReq/Copyright tags.
[x]: SourceX is a working URL.
     Note: The Source URLs are reachable.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
     Note: Build verified on x86_64; ExclusiveArch limits the supported set.
[x]: Spec use %global instead of %define unless justified.
     Note: %global is used; the rpmautospec-generated %define is acceptable.

===== EXTRA items =====

Generic:
[x]: Spec file according to URL is the same as in SRPM.
     Note: URL and SRPM specs differ only by rpmautospec-generated
     release/changelog boilerplate; false positive.
[x]: Rpmlint is run on debuginfo package(s).
     Note: rpmlint on the debuginfo package is clean.
[x]: Rpmlint is run on all installed packages.
     Note: rpmlint on the installed packages ran; the messages are noted
     below.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Large data/noarch handling is fine.

Verification performed:
======================
- Mock build succeeded on fedora-rawhide-x86_64; %check exited 0.
- LICENSE.dependencies inside the RPM matches the compound License expression; license-validate accepts it.
- rpm -qp --provides: npm(oxc-parser) and bundled(nodejs-@oxc-project/types) are present.
- rpm -qp --conflicts is empty.
- No prebuilt .node file is shipped; the addon is built by napi/cargo and loaded by %check.
- Upstream npm latest 0.158.0 matches the package.


Attachments / generated data
=============================

Rpmlint
-------
Checking: nodejs-oxc-parser-0.158.0-1.fc46.x86_64.rpm
          nodejs-oxc-parser-0.158.0-1.fc46.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp6zbu_d1j')]
checks: 32, packages: 2

nodejs-oxc-parser.src: E: spelling-error ('napi', '%description -l en_US napi -> nap, nape, naps')
nodejs-oxc-parser.src: E: spelling-error ('vendored', '%description -l en_US vendored -> vendor ed, vendor-ed, vendor')
nodejs-oxc-parser.x86_64: E: spelling-error ('napi', '%description -l en_US napi -> nap, nape, naps')
nodejs-oxc-parser.x86_64: E: spelling-error ('vendored', '%description -l en_US vendored -> vendor ed, vendor-ed, vendor')
nodejs-oxc-parser.spec: W: invalid-url Source0: oxc-parser-0.158.0-stripped.tar.gz
nodejs-oxc-parser.spec: W: invalid-url Source1: oxc-parser-0.158.0-npm.tgz
nodejs-oxc-parser.spec: W: invalid-url Source2: oxc-parser-0.158.0-nm-prod.tgz
nodejs-oxc-parser.spec: W: invalid-url Source3: oxc-parser-0.158.0-nm-dev.tgz
nodejs-oxc-parser.spec: W: invalid-url Source5: oxc-parser-0.158.0-vendor.tar.xz
 2 packages and 0 specfiles checked; 4 errors, 5 warnings, 9 filtered, 4 badness; has taken 0.8 s 




Rpmlint (debuginfo)
-------------------
Checking: nodejs-oxc-parser-debuginfo-0.158.0-1.fc46.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp05zc45yz')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.6 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.10.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 33, packages: 2

nodejs-oxc-parser.x86_64: W: spelling-error ('napi', '%description -l en_US napi -> nap, nape, naps')
nodejs-oxc-parser.x86_64: W: spelling-error ('vendored', '%description -l en_US vendored -> vendor ed, vendor-ed, vendor')
 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 10 filtered, 0 badness; has taken 0.1 s 



Requires
--------
nodejs-oxc-parser (rpmlib, GLIBC filtered):
    ld-linux-x86-64.so.2()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3)(64bit)
    libgcc_s.so.1(GCC_4.2.0)(64bit)
    libm.so.6()(64bit)
    nodejs(engine)
    nodejs24
    rtld(GNU_HASH)



Provides
--------
nodejs-oxc-parser:
    bundled(nodejs-@oxc-project/types)
    nodejs-oxc-parser
    nodejs-oxc-parser(x86-64)
    npm(oxc-parser)



Diff spec file in url and in SRPM
---------------------------------
--- /home/humaton/projects/fedora/fetch-bz-run-review/2527707-nodejs-oxc-parser/srpm/nodejs-oxc-parser.spec	2026-11-13 09:08:03.089975739 +0100
+++ /home/humaton/projects/fedora/fetch-bz-run-review/2527707-nodejs-oxc-parser/srpm-unpacked/nodejs-oxc-parser.spec	2026-11-11 01:00:00.000000000 +0100
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.8.4)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 # oxc-parser ships as an unscoped npm package (install path
 # %%{nodejs_sitelib}/oxc-parser).  The published npm package is pure JavaScript
@@ -156,3 +166,12 @@
 
 %changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Wed Nov 11 2026 Gordon Messmer <gmessmer> - 0.158.0-1
+- Build 0.158.0
+
+* Tue Oct 27 2026 Gordon Messmer <gmessmer> - 0.156.0-1
+- Update to current release and document bundled licenses
+
+* Wed Aug 19 2026 Gordon Messmer <gmessmer> - 0.127.0-1
+- Package oxc-parser, building the native binding from source
+## END: Generated by rpmautospec


Generated by fedora-review 0.12.0 (a08f0fc) last change: 2026-09-18
Command line :/usr/bin/fedora-review -B -b 2527707
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: fonts, Python, Ruby, Haskell, Perl, SugarActivity, Ocaml, PHP, R, Java
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH, UNRETIREMENT

Comment 5 Fedora Admin user for bugzilla script actions 2026-11-13 20:46:23 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-oxc-parser
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`


Note You need to log in before you can comment on or make changes to this bug.