Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/damiand/scenefx/fedora-rawhide-x86_64/10984315-scenefx/scenefx.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/damiand/scenefx/fedora-rawhide-x86_64/10984315-scenefx/scenefx-0.5-1.fc46.src.rpm Description: scenefx is a drop-in replacement for the wlroots scene API that allows Wayland compositors to render surfaces with eye-candy effects -- including blur, drop shadows, and rounded corners -- while keeping the simplicity of the standard wlroots scene API. It is used by compositors such as SwayFX, MangoWC, and mwc. Fedora Account System Username: damiand This is my first package and i need a sponsor. Feel free to tell me what is wrong with the package and i'll happily change it until it sits right. I'm hoping to start my journey of contributing to fedora. To put you into perspective, i have a deep understanding with upstream since i'm an active contributor to scenefx and maintain the package for Debian.
At first glance it looks fine. It is a bit late on Friday for me so I might not finish it until Monday, but after that I am happy to sponsor
LGTM, APPROVED I'll go ahead and start the sponsorship process Digest from the Matrix conversation: - the library naming (lib%{name}-%{version}.so) is nonstandard. there's now an upstream bug linked tracking it. FWIW wlroots (which this is a drop-in replacement for) also has this issue - tinywl needed to be excluded, it's an example and is CC0 licensed which is no longer allowed Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. CC0 example code removed in %prep [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4465 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: scenefx-0.5-1.fc46.aarch64.rpm scenefx-devel-0.5-1.fc46.aarch64.rpm scenefx-0.5-1.fc46.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp3kbpa7qc')] checks: 32, packages: 3 scenefx.aarch64: E: spelling-error ('wlroots', 'Summary(en_US) wlroots -> roots') scenefx.aarch64: E: spelling-error ('wlroots', '%description -l en_US wlroots -> roots') scenefx.aarch64: E: spelling-error ('mwc', '%description -l en_US mwc -> mic, mac, MW') scenefx.src: E: spelling-error ('wlroots', 'Summary(en_US) wlroots -> roots') scenefx.src: E: spelling-error ('wlroots', '%description -l en_US wlroots -> roots') scenefx.src: E: spelling-error ('mwc', '%description -l en_US mwc -> mic, mac, MW') scenefx-devel.aarch64: W: no-documentation scenefx.spec: W: no-%check-section 3 packages and 0 specfiles checked; 6 errors, 2 warnings, 19 filtered, 6 badness; has taken 0.3 s Rpmlint (debuginfo) ------------------- Checking: scenefx-debuginfo-0.5-1.fc46.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpiqg1c_39')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.10.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 33, packages: 3 scenefx.aarch64: E: spelling-error ('wlroots', 'Summary(en_US) wlroots -> roots') scenefx.aarch64: E: spelling-error ('wlroots', '%description -l en_US wlroots -> roots') scenefx.aarch64: E: spelling-error ('mwc', '%description -l en_US mwc -> mic, mac, MW') scenefx-devel.aarch64: W: no-documentation 3 packages and 0 specfiles checked; 3 errors, 1 warnings, 21 filtered, 3 badness; has taken 0.2 s Unversioned so-files -------------------- scenefx: /usr/lib64/libscenefx-0.5.so Source checksums ---------------- https://github.com/wlrfx/scenefx/archive/refs/tags/0.5/scenefx-0.5.tar.gz : CHECKSUM(SHA256) this package : 0fa8ecca0e310f813efd052624c5ed7d9153d6a0fdead5cc957d34c07f9a86c6 CHECKSUM(SHA256) upstream package : 0fa8ecca0e310f813efd052624c5ed7d9153d6a0fdead5cc957d34c07f9a86c6 Requires -------- scenefx (rpmlib, GLIBC filtered): ld-linux-aarch64.so.1()(64bit) libEGL.so.1()(64bit) libGLESv2.so.2()(64bit) libc.so.6()(64bit) libdrm.so.2()(64bit) libgbm.so.1()(64bit) liblcms2.so.2()(64bit) libm.so.6()(64bit) libpixman-1.so.0()(64bit) libwayland-server.so.0()(64bit) libwlroots-0.20.so()(64bit) rtld(GNU_HASH) scenefx-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config pkgconfig(egl) pkgconfig(gbm) pkgconfig(glesv2) pkgconfig(lcms2) pkgconfig(libdrm) pkgconfig(pixman-1) pkgconfig(wayland-server) pkgconfig(wlroots-0.20) pkgconfig(xkbcommon) scenefx(aarch-64) Provides -------- scenefx: libscenefx-0.5.so()(64bit) scenefx scenefx(aarch-64) scenefx-devel: pkgconfig(scenefx-0.5) scenefx-devel scenefx-devel(aarch-64) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/sbin/fedora-review -b 2529330 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: SugarActivity, fonts, Java, PHP, Python, Ocaml, R, Perl, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/scenefx Monitoring: Anitya project is accessible by this link `https://release-monitoring.org/project/373099` you can modify it manually. Package wasn't created in Anitya, reason: `Bad Request, some necessary arguments were not provided.`.
FEDORA-2026-28dd83ecb8 (scenefx-0.5-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-28dd83ecb8
FEDORA-2026-00c9f81952 (scenefx-0.5-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-00c9f81952
FEDORA-2026-00c9f81952 has been pushed to the Fedora 45 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-00c9f81952 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-00c9f81952 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-28dd83ecb8 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-28dd83ecb8 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-28dd83ecb8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-00c9f81952 (scenefx-0.5-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-28dd83ecb8 (scenefx-0.5-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.