Red Hat Bugzilla – Bug 25307
[patch] `/sbin/pidof: -c: line 2: syntax error: unexpected end of file
Last modified: 2007-04-18 12:30:59 EDT
There is an error message in .xsession-errors after logging in. It is due to the Exec line in Autorun.kdelnk not getting properly expanded: [pid 1982] execve("/bin/bash", ["bash", "-c", "if test -O /dev/console -a -z \\", "`/sbin/pidof", "autorun`\\\"", "-a", "-x", "/usr/bin/autorun;then", "/usr/bin/autorun", "--interval=1000", "--cdplayer=/usr/bin/kscd", "&", "fi\""], [/* 29 vars */]) = 0 There are more parameters than there should be here; I guess the word-splitting code is confused by the double quote. Is it using wordexp (and if not why not)?
This defect is considered MUST-FIX for Florence Release-Candidate #1
There's some _very_ suspicious code in KRun::shellQuote that could be the cause of it. I've ranted about this in another bug, but here's how Exec= lines _ought_ to be expanded: Replace %x with ${x} for each type of x replacement. Set up the environment appropriately to reflect this. Call wordexp. Be happy. This will do quoting for you, and tilde expansion, and parameter expansion, and arithmetic expansion, and even command substitution if you want (optional).
Created attachment 8562 [details] kdelibs-esc.patch
The above patch fixes this behaviour for me. KDE should just use wordexp. ;-) Now autorun actually starts, and prompts me for the root password when I put a Red Hat Linux CD in the drive. Woohoo!
Fixed in CVS.
20010205 package still has this bug. Is the patch applied?
Yes, the patch is in and applied. It's Patch #3 in the current kdelibs source RPM.
Found the problem... is_escaped isn't set in PARSE_DBLQUOTED mode. Fixing.
Fixed in 20010206