Fedora Account System
Red Hat Associate
Red Hat Customer
spec: https://suve.fedorapeople.org/review/python-whodap-0.1.16-1/python-whodap.spec srpm: https://suve.fedorapeople.org/review/python-whodap-0.1.16-1/python-whodap-0.1.16-1.fc45.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=150133320 Description: Python RDAP utility for querying and parsing information about Domains, IPv4s, IPv6s, and AS numbers. Fedora Account System Username: suve
I noticed you use: %pyproject_buildrequires -t but then don't use %tox in %check. Is there a reason? Also, does %pytest work over PYTHONPATH=%{buildroot}%{python3_sitelib} pytest-%{python3_version}?
> I noticed you use: %pyproject_buildrequires -t but then don't use %tox in %check. Is there a reason? Good catch. The reason is that I probably copy-pasted this from another spec that does use tox. > Also, does %pytest work over PYTHONPATH=%{buildroot}%{python3_sitelib} pytest-%{python3_version}? Uhh, I don't think I understand your question. Yes, this invocation works and the tests pass. Dropping the PYTHONPATH bit makes 'em all fail with ModuleNotFoundError. Unless you're asking about the "pytest-%{python3_version}" bit? To be honest, this is also copy-pasted from another spec. Looking through my Python packages, I see others using "%python3 -m pytest tests/" instead. Would that be preferable?
Sorry if I did not phrase it correctly. I meant: Does this change work?: %check -PYTHONPATH=%{buildroot}%{python3_sitelib} pytest-%{python3_version} -v +%pytest -v And if it does, let's use it (unless you will use %tox, which makes it moot). %pytest sets PYTHONPATH for you.
Ah, ok, now I get it. Yes, this change works. Anyway, I've just noticed that since I first submitted this Review Request, upstream released v0.2.1. Updated the package and went with %tox for running the tests. spec: https://suve.fedorapeople.org/review/python-whodap-0.2.1-1/python-whodap.spec srpm: https://suve.fedorapeople.org/review/python-whodap-0.2.1-1/python-whodap-0.2.1-1.fc45.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=151204210