Red Hat Bugzilla – Bug 253322
Review Request: tomsfastmath - A fast public domain, open source, large integer arithmetic library
Last modified: 2008-01-27 17:16:07 EST
Spec URL: http://dev.laptop.org/~coderanger/rpm/tomsfastmath/tomsfastmath.spec
SRPM URL: http://dev.laptop.org/~coderanger/rpm/tomsfastmath/tomsfastmath-0.12-1.fc8.src.rpm
Description: TomsFastMath is a fast public domain, open source, large integer arithmetic library written in portable ISO C. It is a port of LibTomMath with optional support for inline assembler multipliers. It has the following features.
I just did a quick build of this and found some issues:
The debuginfo package seems broken; it doesn't contain any source.
The proper set of CFLAGS aren't used. You can get them in with
at the very beginning of %build, but that still doesn't solve the broken
debuginfo problem. Plus this package adds some additional options like -O3
which are generally frowned upon. Setting IGNORE_SPEED does get rid of those,
but of course you should benchmark to see if it actually makes a difference.
The -devel package doesn't own /usr/include/tomsfastmath/.
It would be nice to package the changes.txt file as documentation, probably in
the -devel package.
Noah just passed this bug over to me, so I'll reply with a new spec and srpm as
soon as I've learned enough to fix the packaging bugs Jason found. Thanks for
I think it's time to close this one. Unless, of course, Mamoru would like to
keep it open or whoever is driving this now would like to give us an updated
package for review.
Closing it sounds wise to me. If I'm ever in a position where I'm able to
maintain the package, I'll reopen it. Please select whatever resolution seems