Spec URL: http://rishi.fedorapeople.org/opyum.spec SRPM URL: http://rishi.fedorapeople.org/opyum-0.0.2-1.fc8.src.rpm Description: Opyum (pronounced 'opium') provides a set of tools to enable users, who do not have a good network (eg., Internet) connection at their ready disposal, to easily install new packages or update existing ones through the conventional package management system available in Fedora.
mock build failed with following error. checking python module: pirut... no configure: error: failed to find required module pirut error: Bad exit status from /var/tmp/rpm-tmp.23798 (%build)
Trying to check for Pirut in the configure script using $ $PYTHON -c "import pirut" gives the following traceback on Koji. The absence of a running X server causes the issue, since the pirut modules eventually pull in gtk too. Traceback (most recent call last): File "<string>", line 1, in <module> File "/usr/lib/python2.5/site-packages/pirut/__init__.py", line 26, in <module> import gtk File "/usr/lib/python2.5/site-packages/gtk-2.0/gtk/__init__.py", line 76, in <module> _init() File "/usr/lib/python2.5/site-packages/gtk-2.0/gtk/__init__.py", line 64, in _init _gtk.init_check() RuntimeError: could not open display It is important to have the check in the upstream tarball, since Pirut is a critical dependency for Opyum and anybody building from the release tarball should be made aware of that. However, I am going to patch out the check for the RPM package since Pirut is already mentioned as a Requires and BuildRequires.
Spec: http://rishi.fedorapeople.org/opyum.spec SRPM: http://rishi.fedorapeople.org/opyum-0.0.2-2.fc8.src.rpm Here is the new pair of Spec & SRPM.
Is this issue discussed on fedora-devel? Not understand why we need to patch pirut dependency? Why can't configure successfully detects it?
I was told in #fedora-devel by ivazquez that patching out the check for pirut in configure would be fine since the Requires and BuildRequires are taking care of that. The configure file basically does: $ $PYTHON -c "import pirut" ...to check for the availability of the Pirut modules. However importing the Pirut modules also imports gtk. Importing Gtk needs DISPLAY to be set and a running X. Although one can take care of DISPLAY, I do not think we have X running on the Koji build servers. Hence the error.
I've never created a configure script before but from what I understand it's a bash script... this would work: python_sitelib=$(python -c "from distutils.sysconfig import get_python_lib; print get_python_lib()") echo -n "Checking for pirut... " if [ -d "$python_sitelib/pirut" ];then echo "Yes, $python_sitelib/pirut" else echo 'No' fi
remove python as BR in spec file
ok let it be as it is BR: python Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPMs. + source files match upstream. 299873e5d0b4d762a261edb6b9bc62e6 opyum-0.0.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + no -doc subpackage. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + gtk-update-icon-cache scriptlets are used. + Desktop files handled correctly. + Requires: /bin/bash /usr/bin/python hicolor-icon-theme pirut >= 1.3.11 + GUI APP. APPROVED.
New Package CVS Request ======================= Package Name: opyum Short Description: Offline package installation and update tools. Owners: debarshi.ray Branches: FC-6, F-7 InitialCC: Cvsextras Commits: no
Please re-request using your FAS username in the Owners field.
New Package CVS Request ======================= Package Name: opyum Short Description: Offline package installation and update tools. Owners: rishi Branches: FC-6, F-7 InitialCC: Cvsextras Commits: no
cvs done.
is this built already? If yes then you can close this review request.
I have not built it due to some problems with my workstation. I will soon release version 0.0.3 and close this bug after building it.
ping? The branch has been created but the source package still hasn't been imported or built.
Imported and built for Rawhide.