Bug 2535416 - Review Request: rust-vhost-device-media - Virtio-media device using the vhost-user protocol
Summary: Review Request: rust-vhost-device-media - Virtio-media device using the vhost...
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Javier Martinez Canillas
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2026-09-16 13:05 UTC by Albert Esteve
Modified: 2026-10-16 11:54 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
javierm: fedora-review+


Attachments (Terms of Use)

Comment 1 Fabio Valentini 2026-09-18 13:39:26 UTC
Note, this project is already packaged for Fedora:
https://src.fedoraproject.org/rpms/rust-vhost-device-sound

Comment 2 Albert Esteve 2026-09-18 14:20:33 UTC
True, my bad! It was a copy+paste error. FIxed.

Comment 3 Javier Martinez Canillas 2026-09-30 10:25:46 UTC
The package looks good to me. Following is the result of fedora-review,
I've reviewed the items that required manual review and as far as I can
tell this package is OK.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/


===== MUST items =====

C/C++:
[ ]: Package does not contain kernel modules.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License 2.0",
     "BSD 3-Clause License", "Apache License (v2.0) or
     bsd_-3-Clause_clause", "*No copyright* The Unlicense", "MIT License",
     "*No copyright* MIT License", "*No copyright* Apache License (v2.0) or
     MIT license", "ISC License", "Apache License 2.0 and/or BSD 3-Clause
     License", "Apache License 2.0 and/or GNU Lesser General Public License
     v2.1 or later and/or MIT License", "Apache License (v2.0) or MIT
     license", "Apache License 2.0", "Unicode License Agreement - Data
     Files and Software (2016)", "*No copyright* BSD 3-Clause License",
     "BSD 2-Clause License", "Apache License (v2.0) or MIT license and/or
     MIT License", "*No copyright* Apache License (v2.0) or MIT license
     and/or MIT License", "*No copyright* BSD 2-Clause License", "*No
     copyright* GNU General Public License, Version 2". 8697 files have
     unknown license. Detailed output of licensecheck in /tmp/2535416-rust-
     vhost-device-media/licensecheck.txt
[ ]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 4373 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[ ]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[ ]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define autorelease(e:s:pb:n)
     %{?-p:0.}%{lua:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: vhost-device-media-0.1.1-2.fc46.x86_64.rpm
          rust-vhost-device-media-0.1.1-2.fc46.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpwmooku92')]
checks: 32, packages: 2

rust-vhost-device-media.src: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso')
rust-vhost-device-media.src: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso')
vhost-device-media.x86_64: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso')
vhost-device-media.x86_64: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso')
vhost-device-media.x86_64: W: no-manual-page-for-binary vhost-device-media
rust-vhost-device-media.spec: W: invalid-url Source1: vhost-device-media-0.1.1-vendor.tar.xz
 2 packages and 0 specfiles checked; 4 errors, 2 warnings, 7 filtered, 4 badness; has taken 0.6 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.10.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 33, packages: 1

vhost-device-media.x86_64: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso')
vhost-device-media.x86_64: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso')
vhost-device-media.x86_64: W: no-manual-page-for-binary vhost-device-media
 1 packages and 0 specfiles checked; 2 errors, 1 warnings, 3 filtered, 2 badness; has taken 0.2 s 



Source checksums
----------------
https://crates.io/api/v1/crates/vhost-device-media/0.1.1/download#/vhost-device-media-0.1.1.crate :
  CHECKSUM(SHA256) this package     : 0cb983841c712d20fb5d6d49d29b28bd17a82cfbb6412b1e9f32bc4bd0edccf6
  CHECKSUM(SHA256) upstream package : 0cb983841c712d20fb5d6d49d29b28bd17a82cfbb6412b1e9f32bc4bd0edccf6


Requires
--------
vhost-device-media (rpmlib, GLIBC filtered):
    ld-linux-x86-64.so.2()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3)(64bit)
    libgcc_s.so.1(GCC_4.2.0)(64bit)
    rtld(GNU_HASH)



Provides
--------
vhost-device-media:
    bundled(crate(aho-corasick))
    bundled(crate(anstream))
    bundled(crate(anstyle))
    bundled(crate(anstyle-parse))
    bundled(crate(anstyle-query))
    bundled(crate(anstyle-wincon))
    bundled(crate(anyhow))
    bundled(crate(arc-swap))
    bundled(crate(assert_matches))
    bundled(crate(bindgen))
    bundled(crate(bitflags))
    bundled(crate(cexpr))
    bundled(crate(cfg-if))
    bundled(crate(cfg_aliases))
    bundled(crate(chacha20))
    bundled(crate(clang-sys))
    bundled(crate(clap))
    bundled(crate(clap_builder))
    bundled(crate(clap_derive))
    bundled(crate(clap_lex))
    bundled(crate(colorchoice))
    bundled(crate(cpufeatures))
    bundled(crate(either))
    bundled(crate(enumn))
    bundled(crate(env_filter))
    bundled(crate(env_logger))
    bundled(crate(equivalent))
    bundled(crate(errno))
    bundled(crate(fastrand))
    bundled(crate(futures-core))
    bundled(crate(futures-macro))
    bundled(crate(futures-task))
    bundled(crate(futures-timer))
    bundled(crate(futures-util))
    bundled(crate(getrandom))
    bundled(crate(glob))
    bundled(crate(hashbrown))
    bundled(crate(heck))
    bundled(crate(indexmap))
    bundled(crate(is_terminal_polyfill))
    bundled(crate(itertools))
    bundled(crate(jiff))
    bundled(crate(jiff-core))
    bundled(crate(jiff-static))
    bundled(crate(libc))
    bundled(crate(libloading))
    bundled(crate(linux-raw-sys))
    bundled(crate(log))
    bundled(crate(memchr))
    bundled(crate(minimal-lexical))
    bundled(crate(nix))
    bundled(crate(nom))
    bundled(crate(once_cell))
    bundled(crate(once_cell_polyfill))
    bundled(crate(paste))
    bundled(crate(pastey))
    bundled(crate(pin-project-lite))
    bundled(crate(portable-atomic))
    bundled(crate(portable-atomic-util))
    bundled(crate(prettyplease))
    bundled(crate(proc-macro-crate))
    bundled(crate(proc-macro2))
    bundled(crate(quote))
    bundled(crate(r-efi))
    bundled(crate(rand))
    bundled(crate(rand_core))
    bundled(crate(regex))
    bundled(crate(regex-automata))
    bundled(crate(regex-syntax))
    bundled(crate(relative-path))
    bundled(crate(rstest))
    bundled(crate(rstest_macros))
    bundled(crate(rustc-hash))
    bundled(crate(rustc_version))
    bundled(crate(rustix))
    bundled(crate(rustversion))
    bundled(crate(semver))
    bundled(crate(shlex))
    bundled(crate(slab))
    bundled(crate(strsim))
    bundled(crate(syn))
    bundled(crate(tempfile))
    bundled(crate(thiserror))
    bundled(crate(thiserror-impl))
    bundled(crate(toml_datetime))
    bundled(crate(toml_edit))
    bundled(crate(toml_parser))
    bundled(crate(unicode-ident))
    bundled(crate(utf8parse))
    bundled(crate(uuid))
    bundled(crate(v4l2r))
    bundled(crate(vhost))
    bundled(crate(vhost-user-backend))
    bundled(crate(virtio-bindings))
    bundled(crate(virtio-media))
    bundled(crate(virtio-queue))
    bundled(crate(vm-memory))
    bundled(crate(vmm-sys-util))
    bundled(crate(winapi))
    bundled(crate(winapi-i686-pc-windows-gnu))
    bundled(crate(winapi-x86_64-pc-windows-gnu))
    bundled(crate(windows-link))
    bundled(crate(windows-sys))
    bundled(crate(winnow))
    bundled(crate(zerocopy))
    bundled(crate(zerocopy-derive))
    vhost-device-media
    vhost-device-media(x86-64)



Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/usr/bin/fedora-review -b 2535416
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Generic, Shell-api
Disabled plugins: R, Java, PHP, Ocaml, Python, Perl, Haskell, SugarActivity, fonts
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment 4 Jens Petersen 2026-10-16 11:54:13 UTC
I can help to sponsor Albert I think


Note You need to log in before you can comment on or make changes to this bug.