Red Hat Bugzilla – Bug 253579
Review Request: php-pecl-memcache - Extension to work with the Memcached caching daemon
Last modified: 2007-11-30 17:12:13 EST
Spec URL: http://remi.fedorapeople.org/php-pecl-memcache.spec SRPM URL: http://remi.fedorapeople.org/php-pecl-memcache-2.1.2-1.fc8.src.rpm Mock log: http://remi.fedorapeople.org/php-pecl-memcache-build.log Description: Memcached is a caching daemon designed especially for dynamic web applications to decrease database load by storing objects in memory. This extension allows you to work with memcached through handy OO and procedural interfaces. -- Note : this package register the PECL extension (as PEAR ones). This is not yet in the PHP Guidelines (but nothing against).
I Add Matthias in CC: as is the maintener for this package at rpmforge. @Matthias : my spec is closed to your. We can work as co-maintener for this if you want. I will push it to Fedora and EPEL after review. Remi.
Veeeery nice, clean and portable spec file. This will be a real pleasure to review. Thanks for CC'ing me, feel free to do it again ;-)
I just went through the ReviewGuidelines, double checked the license and tested a Fedora 7 x86_64 build. It all looks fine. Just two minor nitpicks : - Some sections of your spec file are separated by 2 spaces, others only by one. It would be more readable if all were separated by 2 IMHO :-) (before %prep, %build and %changelog). - It's harmless here, but you should always escape macros in comments and the %changelog, so change "use %name rather than %pecl_name" to "use %%name rather than %%pecl_name" or even simply "use name rather than pecl_name". Again, no big deal, but if some day you put some multi-line macro, it'll do nasty stuff ;-) APPROVED even as-is in any case, great work on PHP packaging, keep it up!
New Package CVS Request ======================= Package Name: php-pecl-memcache Short Description: Extension to work with the Memcached caching daemon Owners: remi Branches: F-7, FC-6, EL-5, EL-4 InitialCC: Cvsextras Commits: yes
request done
Push to CVS with typo changes. Thanks for the review.