Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://jjames.fedorapeople.org/python-hiveplotlib/python-hiveplotlib.spec SRPM URL: https://jjames.fedorapeople.org/python-hiveplotlib/python-hiveplotlib-0.28.0-1.fc46.src.rpm Fedora Account System Username: jjames Description: The hiveplotlib package supports generating and visualizing static Hive Plots in Python. By default, visualization is supported with the matplotlib backend only, but bokeh support is also available. Beyond the visualization backends, hiveplotlib integrates with networkx: build a hive plot directly from a networkx graph and compute graph metrics on it. I am willing to swap reviews.
rpmlint output is fine: python-hiveplotlib.src: E: spelling-error ('matplotlib', '%description -l en_US matplotlib -> plotline') python-hiveplotlib.src: E: spelling-error ('bokeh', '%description -l en_US bokeh -> bookend') python-hiveplotlib.src: E: spelling-error ('networkx', '%description -l en_US networkx -> network, networks, network x') python3-hiveplotlib.noarch: E: spelling-error ('matplotlib', '%description -l en_US matplotlib -> plotline') python3-hiveplotlib.noarch: E: spelling-error ('bokeh', '%description -l en_US bokeh -> bookend') * Follows package guidelines * Builds in mock. * Tests are enabled This Summary is a copy paste error ? Summary: Sphinx extensions for working with LaTeX math Otherwise seems fine, nice an simple. If you could take a look at https://bugzilla.redhat.com/show_bug.cgi?id=2542620 that would be great. Similarly easy I would hope.
Oops, yes, copy & paste error indeed. I have fixed it: Spec URL: https://jjames.fedorapeople.org/python-hiveplotlib/python-hiveplotlib.spec SRPM URL: https://jjames.fedorapeople.org/python-hiveplotlib/python-hiveplotlib-0.28.0-1.fc46.src.rpm I will review bug 2542620. Thank you!
Hi, I'll formal review it and almost certainly approve tomorrow. A question though: You added a VCS: tag. Is that now a thing? I ask because our Koji instance (not fedora) actually adds these with a link back to the dist-url. Is the VCS tag now something we expect to be populated up front
(In reply to Steve Traylen from comment #3) > A question though: > > You added a VCS: tag. > > Is that now a thing? I ask because our Koji instance (not fedora) actually > adds these with a link back to the dist-url. > > Is the VCS tag now something we expect to be populated up front Are you sure? This is in a Rawhide mock chroot: <mock-chroot> sh-5.3# rpm -q --queryformat "%{VCS}\n" glibc (none) <mock-chroot> sh-5.3# rpm -q --queryformat "%{VCS}\n" readline (none) <mock-chroot> sh-5.3# rpm -q --queryformat "%{VCS}\n" zstd (none) <mock-chroot> sh-5.3# rpm -q --queryformat "%{VCS}\n" mpfr git:https://gitlab.inria.fr/mpfr/mpfr.git The VCS tag in the mpfr package is one I added myself. I've poked around a bit and haven't found any of these auto-generated VCS tags you are talking about. Where did you hear about them? I've been adding VCS tags manually since shortly after RPM added that tag.
APPROVED (fedora-review does not like the new fancy .spec file it seems) > I ask because our Koji instance (not fedora) actually adds these with a link back to the dist-url. I looked into this, seems I did not know how our build service worked. We add the VCS tag in the build pipeline before submitting to koji so my question is irrelevant. Thanks for the review of pytest-describe.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-hiveplotlib Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
Gotcha. Thanks for looking into it, and thank you for the review!
FEDORA-2026-2d672a4851 (python-hiveplotlib-0.28.0-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-2d672a4851
FEDORA-2026-1bdcb2a86c (python-hiveplotlib-0.28.0-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-1bdcb2a86c
FEDORA-2026-1bdcb2a86c has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-1bdcb2a86c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-1bdcb2a86c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-2d672a4851 has been pushed to the Fedora 45 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-2d672a4851 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-2d672a4851 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.