+++ This bug was initially created as a clone of Bug #253161 +++ Description of problem: fonts-chinese contains a number of different fonts, they should be moved to packages that reflect the upstream project's name as far as possible: eg to arphic-fonts and taipei-fonts. -- Additional comment from cchance on 2007-08-19 07:58 EST -- Excuse me to ask, how could this proposal conserve the current convenience for user to install formal chinese fonts when it is carried out? -- Additional comment from petersen on 2007-08-19 20:42 EST -- fonts-chinese will require the new fonts packages.
Add license file in tarball. Change License tag to one of compatible licenses allowed. add postun section Change buildroot why Obsolete needed? Is taipeifonts package present in fedora currently?
http://cchance.fedorapeople.org/20070822_taipei/taipei-fonts.spec http://cchance.fedorapeople.org/20070822_taipei/taipei-fonts-0.1-1.fc8.src.rpm
It seems taipei-1.2.tar.gz seems to originate from the CLE (Chinese Linux Extension) to Slackware from bitmaps taken from XFree86 perhaps. Anyway I managed to track down a potential new upstream since taipei16 and taipei24 are included in GNU's intlfonts distribution. ftp://ftp.gnu.org/gnu/intlfonts/ The current version is 1.2.1. http://directory.fsf.org/localization/intlfonts.html lists the distribution as GPLv2+, verified by the FSF in 2001. There is no COPYING or license file included in the tarball(s) though. It would be good to ask Handa-san for clarification about that perhaps.
So probably the Chinese.tar.gz in ftp://ftp.gnu.org/gnu/intlfonts/intlfonts-1.2.1-split/ is a good candidate to replace taipeifonts.
Oh and I just found: http://ftp2.tnc.edu.tw/pub3/CLE/CLE/devel/wjwu/slackware/slackware-9.1/source/taipeifonts-1.2/re-build.readme which claims the taipei fonts are Public Domain. The taipei fonts are available here: ftp://cle.linux.org.tw/pub2/fonts/bitmap/taipeifont
I think Jens can be good Reviewer for this package. Removing myself from review.
bump: reminding Jens =)
Thanks - Caius should be back next week from holiday.
I suggest let's rename it to taipeifonts if that is the upstream name. taipeifonts.src: W: no-url-tag Is there URL for this? taipeifonts.noarch: W: no-documentation taipeifonts.noarch: W: no-url-tag Any documentation files available? intlfonts-1.2.1/Korean.X/README reads: Koean Hangle&Hanja (KSC5601): hanglg16.bdf from X.V11R5/mit/bdf/fonts/misc hanglm16.bdf ... hanglm24.bdf ...
Created attachment 204781 [details] taipeifonts.spec-1.patch cleanup patch
Patched from comment #11: http://fedorapeople.org/~cchance/20070925_taipeifonts/taipeifonts-1.2-2.fc8.noarch.rpm http://fedorapeople.org/~cchance/20070925_taipeifonts/taipeifonts.spec
How about a url for the source?
(BTW I can't reach ftp://cle.linux.org.tw/pub2/fonts/bitmap/taipeifont currently.)
Review follows: Good: + rpmlint clean + name follows upstream name (from CLE project) + meets packaging guidelines + fonts are public domain (no license file is included) + spec file is clear + dir and file ownership is good + macros used Needs attention: - no source url - noarch package builds - buildreqs listed Dunno if it is not a good idea to include say http://ftp2.tnc.edu.tw/pub3/CLE/CLE/devel/wjwu/slackware/slackware-9.1/source/taipeifonts-1.2/re-build.readme
correction "- noarch package builds" should have been in the "Good" section.
ugh, sorry, "buildreqs listed" should also have been under Good.
How about http://ftp2.tnc.edu.tw/pub3/CLE/CLE/devel/wjwu/slackware/slackware-9.1/source/taipeifonts-1.2/%{name}-%{version}.tar.gz for the source url? Do you have a better one? Also I just noticed the "Buildroot" should updated to the current recommendations: http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473
Would if be the following, because there is/will be only version 1.2 foreseeable? http://ftp2.tnc.edu.tw/pub3/CLE/CLE/devel/wjwu/slackware/slackware-9.1/source/taipeifonts-1.2/taipeifonts-1.2.tar.gz BTW, BuildRoot was updated to the current recommendation: http://fedorapeople.org/~cchance/20070927_taipeifonts/taipeifonts-1.2-3.fc8.src.rpm http://fedorapeople.org/~cchance/20070927_taipeifonts/taipeifonts.spec
URL field is for the project webpage not the source. So we want one url for URL and one for SOURCE. How about: URL: http://cle.linux.org.tw/ Though they don't mention taipeifonts on the website directly anymore I think it is respectful to acknowledge the work of CLE here. Source0: http://ftp2.tnc.edu.tw/pub3/CLE/CLE/devel/wjwu/slackware/slackware-9.1/source/taipeifonts-1.2/taipeifonts-1.2.tar.gz using %{name}-%{version}.tar.gz is better since it shows that the name and version follows upstream. Add Source2: http://ftp2.tnc.edu.tw/pub3/CLE/CLE/devel/wjwu/slackware/slackware-9.1/source/taipeifonts-1.2/re-build.readme
Created attachment 209341 [details] taipeifonts.spec-2.patch Here is a patch with a better base url.
http://fedorapeople.org/~cchance/20070928_taipeifonts/taipeifonts-1.2-3.fc8.src.rpm http://fedorapeople.org/~cchance/20070928_taipeifonts/taipeifonts.spec
Source of README should be treated same as other sources: i.e. from http://ftp2.tnc.edu.tw/pub3/CLE/CLE/devel/wjwu/slackware/slackware-9.1/source/taipeifonts-1.2/re-build.readme to Source2: ftp://cle.linux.org.tw/pub/CLE/devel/wjwu/slackware/slackware-10.0/source/%{name}-%{version}/re-build.readme
taipeifonts.noarch: W: incoherent-version-in-changelog 1.2-4 1.2-3.fc7 Please bump the release. Also please preserve the timestamp of the readme file in %prep with "cp -p".
http://fedorapeople.org/~cchance/20070928_taipeifonts/taipeifonts-1.2-4.fc8.src.rpm http://fedorapeople.org/~cchance/20070928_taipeifonts/taipeifonts.spec
For the record here is the md5sum of the source tarball: 9e4acdd5a218dea6aaa28bc80d472aad taipeifonts-1.2.tar.gz which coincides with the one from CLE. Thanks for the review. This package is APPROVED.
New Package CVS Request ======================= Package Name: taipeifonts Short Description: Chinese bitmap fonts. Owners: cchance Branches: devel InitialCC: Cvsextras Commits: yes
cvsadmin done
Built into rawhide.
New Package CVS Request ======================= Package Name: taipeifonts Short Description: Chinese bitmap fonts Owners: kaio Branches: F-13 InitialCC: i18n-team
F13 branch added.
taipeifonts-1.2-12.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/taipeifonts-1.2-12.fc13
taipeifonts-1.2-12.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update taipeifonts'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/taipeifonts-1.2-12.fc13
taipeifonts-1.2-12.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.