Fedora Account System
Red Hat Associate
Red Hat Customer
spec: https://suve.fedorapeople.org/review/libresprite-1.2-1/libresprite.spec srpm: https://suve.fedorapeople.org/review/libresprite-1.2-1/libresprite-1.2-1.fc45.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=150531180 Description: LibreSprite lets you create 2D animations for video games. From sprites, to pixel-art, retro style graphics, and whatever else you like about the 8-bit (and 16-bit) era. Fedora Account System Username: suve
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/licenses/libresprite [!]: Package must own all directories that it creates. /usr/share/licenses/libresprite [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 33135 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libresprite-1.2-1.fc46.x86_64.rpm libresprite-data-1.2-1.fc46.noarch.rpm libresprite-1.2-1.fc46.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpjyw3ib8w')] checks: 32, packages: 3 libresprite.src: E: spelling-error ('videogames', '%description -l en_US videogames -> video games, video-games, Vietnamese') libresprite.x86_64: E: spelling-error ('videogames', '%description -l en_US videogames -> video games, video-games, Vietnamese') libresprite-data.noarch: E: spelling-error ('et', '%description -l en_US et -> ET, ETA, eat') libresprite-data.noarch: E: spelling-error ('cetera', '%description -l en_US cetera -> ceteris, ceders, ceder') libresprite.x86_64: W: no-manual-page-for-binary libresprite libresprite.x86_64: W: no-manual-page-for-binary libresprite-thumbnailer libresprite.spec:140: W: mixed-use-of-spaces-and-tabs (spaces: line 140, tab: line 112) libresprite.src: W: invalid-license MIT Unlicense BSD-3-Clause libresprite.x86_64: W: invalid-license MIT Unlicense BSD-3-Clause libresprite-data.noarch: W: invalid-license MIT Unlicense BSD-3-Clause libresprite-data.noarch: E: incorrect-fsf-address /usr/share/licenses/libresprite/LibreSprite-GPLv2.txt libresprite-data.noarch: W: dangling-relative-symlink /usr/share/libresprite/data/fonts/font-ar.ttf ../../../fonts/google-noto/NotoKufiArabic-Regular.ttf libresprite-data.noarch: W: dangling-relative-symlink /usr/share/libresprite/data/fonts/font-jp.ttf ../../../fonts/google-noto-sans-jp-fonts/NotoSansJP-Regular.otf libresprite-data.noarch: W: dangling-relative-symlink /usr/share/libresprite/data/fonts/font-kr.ttf ../../../fonts/google-noto-sans-kr-fonts/NotoSansKR-Regular.otf libresprite-data.noarch: W: dangling-relative-symlink /usr/share/libresprite/data/fonts/font-zh.ttf ../../../fonts/google-noto-sans-sc-fonts/NotoSansSC-Regular.otf libresprite-data.noarch: W: dangling-relative-symlink /usr/share/libresprite/data/fonts/font.ttf ../../../fonts/google-noto-vf/NotoSans[wght].ttf 3 packages and 0 specfiles checked; 5 errors, 11 warnings, 18 filtered, 5 badness; has taken 0.7 s Rpmlint (debuginfo) ------------------- Checking: libresprite-debuginfo-1.2-1.fc46.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpwd5w51pp')] checks: 32, packages: 1 libresprite-debuginfo.x86_64: W: invalid-license MIT Unlicense BSD-3-Clause 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 4 filtered, 0 badness; has taken 1.8 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.10.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 33, packages: 3 libresprite-data.noarch: W: spelling-error ('et', '%description -l en_US et -> ET, wt, rt') libresprite-data.noarch: W: spelling-error ('cetera', '%description -l en_US cetera -> terrace, lacerate, macerate') libresprite.x86_64: W: spelling-error ('videogames', '%description -l en_US videogames -> video games, video-games, videotapes') libresprite.x86_64: W: no-manual-page-for-binary libresprite libresprite.x86_64: W: no-manual-page-for-binary libresprite-thumbnailer libresprite-debuginfo.x86_64: W: invalid-license MIT Unlicense BSD-3-Clause libresprite-data.noarch: W: invalid-license MIT Unlicense BSD-3-Clause libresprite.x86_64: W: invalid-license MIT Unlicense BSD-3-Clause libresprite-data.noarch: E: incorrect-fsf-address /usr/share/licenses/libresprite/LibreSprite-GPLv2.txt libresprite-data.noarch: W: dangling-relative-symlink /usr/share/libresprite/data/fonts/font-ar.ttf ../../../fonts/google-noto/NotoKufiArabic-Regular.ttf libresprite-data.noarch: W: dangling-relative-symlink /usr/share/libresprite/data/fonts/font-jp.ttf ../../../fonts/google-noto-sans-jp-fonts/NotoSansJP-Regular.otf libresprite-data.noarch: W: dangling-relative-symlink /usr/share/libresprite/data/fonts/font-kr.ttf ../../../fonts/google-noto-sans-kr-fonts/NotoSansKR-Regular.otf libresprite-data.noarch: W: dangling-relative-symlink /usr/share/libresprite/data/fonts/font-zh.ttf ../../../fonts/google-noto-sans-sc-fonts/NotoSansSC-Regular.otf libresprite-data.noarch: W: dangling-relative-symlink /usr/share/libresprite/data/fonts/font.ttf ../../../fonts/google-noto-vf/NotoSans[wght].ttf 3 packages and 0 specfiles checked; 1 errors, 13 warnings, 17 filtered, 1 badness; has taken 0.2 s Source checksums ---------------- https://github.com/LibreSprite/LibreSprite/archive/v1.2/LibreSprite-v1.2.tar.gz : CHECKSUM(SHA256) this package : bfc2b1c83847feb390d248f1df8f9264dbd885d9fbea2a6303cd26f42b939400 CHECKSUM(SHA256) upstream package : bfc2b1c83847feb390d248f1df8f9264dbd885d9fbea2a6303cd26f42b939400 https://github.com/aseprite/clip/archive/94693e2414a2c69a8ca16f065240c80a94cc6221/clip-94693e2414a2c69a8ca16f065240c80a94cc6221.tar.gz : CHECKSUM(SHA256) this package : 5191f76ddd7baa87d1f500acd470019aaf9aedf075dcf0d614de1307a1f15701 CHECKSUM(SHA256) upstream package : 5191f76ddd7baa87d1f500acd470019aaf9aedf075dcf0d614de1307a1f15701 https://github.com/aseprite/flic/archive/876ef60df5fec606f8eb0638ee893e4967db4673/flic-876ef60df5fec606f8eb0638ee893e4967db4673.tar.gz : CHECKSUM(SHA256) this package : e66ab8d28c630a80a2be2baf260f87481ca7b0d35101e74b3ef131f47989d1a9 CHECKSUM(SHA256) upstream package : e66ab8d28c630a80a2be2baf260f87481ca7b0d35101e74b3ef131f47989d1a9 https://github.com/aseprite/undo/archive/f39b188e29d0f9adaa49c8705c0f492939d967a9/undo-f39b188e29d0f9adaa49c8705c0f492939d967a9.tar.gz : CHECKSUM(SHA256) this package : 8881e3d4c7d9d29c91640649ad8d292be5646fa3fd26be6b49bba1d00e38acba CHECKSUM(SHA256) upstream package : 8881e3d4c7d9d29c91640649ad8d292be5646fa3fd26be6b49bba1d00e38acba Requires -------- libresprite (rpmlib, GLIBC filtered): /usr/bin/sh hicolor-icon-theme libSDL2-2.0.so.0()(64bit) libSDL2_image-2.0.so.0()(64bit) libXi.so.6()(64bit) libarchive.so.13()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libduktape.so.207()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgif.so.7()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libm.so.6()(64bit) libnode.so.147()(64bit) libpixman-1.so.0()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libresprite-data libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtinyxml2.so.11()(64bit) libwebp.so.7()(64bit) libxcb.so.1()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) libresprite-data (rpmlib, GLIBC filtered): font(notokufiarabic) font(notosans) font(notosansjp) font(notosanskr) font(notosanssc) Provides -------- libresprite: application() application(libresprite.desktop) bundled(EasyTab) bundled(modp_b64) bundled(observable) libresprite libresprite(x86-64) metainfo() metainfo(io.github.libresprite.libresprite.metainfo.xml) mimehandler(image/bmp) mimehandler(image/gif) mimehandler(image/jpeg) mimehandler(image/png) mimehandler(image/vnd.microsoft.icon) mimehandler(image/webp) mimehandler(image/x-aseprite) mimehandler(image/x-pcx) mimehandler(image/x-tga) mimehandler(video/x-flic) libresprite-data: libresprite-data Issues: - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPL-2.0-only AND MIT Unlicense BSD-3-Clause'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 I thinkyi you want "and" in between here. - Can you explain why this is done, simply using the %license macro would be much simpler? # Install the license files and documentation. # This is done manually so the files end up in libresprite/ directory # despite being part of libresprite-data package. install -m 755 -d %{buildroot}%{licensedir} install -m 644 -p LICENSE.txt %{buildroot}%{licensedir}/LibreSprite-GPLv2.txt install -m 644 -p docs/licenses/MIT.txt %{buildroot}%{licensedir}/LibreSprite-MIT.txt install -m 644 -p third_party/EasyTab/LICENSE %{buildroot}%{licensedir}/EasyTab.txt install -m 644 -p third_party/modp_b64/LICENSE %{buildroot}%{licensedir}/modp_b64.txt - Minor issue with desktop file desktop-file-validate /export/BUILD/libresprite-1.2-build/BUILDROOT/usr/share/applications/libresprite.desktop /BUILD/libresprite-1.2-build/BUILDROOT/usr/share/applications/libresprite.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated - Wist list: Report to upstream: incorrect-fsf-address /usr/share/licenses/libresprite/LibreSprite-GPLv2.txt Some open review request: Review Request: python-pypsrp - PowerShell Remoting Protocol and WinRM for Python https://bugzilla.redhat.com/show_bug.cgi?id=2526026 Review Request: python-yaspin - Yet Another Terminal Spinner for Python (edit) https://bugzilla.redhat.com/show_bug.cgi?id=2553740
> - The License field must be a valid SPDX expression. > [...] > I thinkyi you want "and" in between here. Yes, it is missing an "AND" between "MIT" and "Unlicense. > - Can you explain why this is done, simply using the %license macro > would be much simpler? Uhh... it's done for exactly the reason described in the comment. The files are packaged in libresprite-data, so using the %license macro would put them in /usr/share/licenses/libresprite-data/, whereas I want them in /usr/share/licenses/libresprite/.
Just use %license macro in both packages instead?
libresprite requires libresprite-data, so it does not need to carry license files. I wanted to move licenses to the -data subpackage since that one is noarch.
Somewhat non-standard, but not end of the world, the license directory need to be owned by package
* Fixed the license tag. * Made the package own the license directory, instead of owning just the files inside. * Moved "Requires: hicolor-icon-theme" to the -data subpackage, as that's where the icon is shipped. spec: https://suve.fedorapeople.org/review/libresprite-1.2-2/libresprite.spec srpm: https://suve.fedorapeople.org/review/libresprite-1.2-2/libresprite-1.2-2.fc45.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=151779127
Thanks, package is APPROVED
The Pagure repository was created at https://src.fedoraproject.org/rpms/libresprite Monitoring: Anitya project is accessible by this link `https://release-monitoring.org/project/153525` you can modify it manually. Package wasn't created in Anitya, reason: `Bad Request, some necessary arguments were not provided.`.
FEDORA-2026-d6407ecde2 (libresprite-1.2-2.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-d6407ecde2
FEDORA-2026-c203a01ed4 (libresprite-1.2-2.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-c203a01ed4
FEDORA-2026-d6407ecde2 has been pushed to the Fedora 45 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-d6407ecde2 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-d6407ecde2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-c203a01ed4 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-c203a01ed4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-c203a01ed4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-d6407ecde2 (libresprite-1.2-2.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.