Spec URL: http://flyn.org/SRPMS/cgi-util.spec SRPM URL: http://flyn.org/SRPMS/cgi-util-2.2.1-9.src.rpm Description: cgi-util is a library which provides a set of C functions you can use to create Common Gateway Interface ("CGI") programs. Simply call cgi-util's initialization function and send HTML (or any other kind of data) out from your program and to the user's web browser. This package was orphaned more than six months ago.
Spec URL: http://flyn.org/SRPMS/cgi-util.spec SRPM URL: http://flyn.org/SRPMS/cgi-util-2.2.1-10.src.rpm Modified the autotools patch.
For 2.2.1-10: * autotools patch - Please don't use a meaninglessly large patch like Patch0. This type of patch makes it very difficult to for us to check what points are to be fixed by this patch. * Apply patch for the points that are really needed fixing and really call autotools if needed. * And please check it carefully if autotools really has to be called. * disttag - Please consider to use disttag. http://fedoraproject.org/wiki/Packaging/DistTag * License - License should be "LGPLv2+" as no source specifies the version. * Macro style - Please choose whether you use %name or %{name} * rpmlint ------------------------------------------------------- cgi-util.i386: W: spurious-executable-perm /usr/share/doc/cgi-util-2.2.1/test.cgi cgi-util.i386: W: spurious-executable-perm /usr/share/doc/cgi-util-2.2.1/filetest.cgi ------------------------------------------------------- - First of all, these two files are actually wrong because these files uses non-existing builddir. i.e. These two files can work at build time and no longer works when installed as this - And the permission should be 0644 as this is marked as documents.
Spec URL: http://flyn.org/SRPMS/cgi-util.spec SRPM URL: http://www.flyn.org/SRPMS/cgi-util-2.2.1-12.fc8.src.rpm
Well, -12 srpm contains some problems. * Builds does not honor Fedora specific compilation flags. * libcgi-util.so does not have soname -------------------------------------------------- gcc -g -Wall -ansi -pedantic -fPIC cgi-util.c -c -o libcgi-util.o gcc -shared libcgi-util.o -o libcgi-util.so -------------------------------------------------- You must use linker option. * Permission of the library is not right -------------------------------------------------- + /usr/bin/install -D -m 0644 libcgi-util.so /var/tmp/cgi-util-2.2.1-12.fc8-root-kojibuilder/usr/lib/libcgi-util.so.2.2.1 -------------------------------------------------- Permission should be 0755. * And for symlink: -------------------------------------------------- + ln -s /usr/lib/libcgi-util.so.2.2.1 /var/tmp/cgi-util-2.2.1-12.fc8-root-kojibuilder/usr/lib/libcgi-util.so -------------------------------------------------- This symlink must be relative.
Spec URL: http://flyn.org/SRPMS/cgi-util.spec SRPM URL: http://www.flyn.org/SRPMS/cgi-util-2.2.1-13.fc8.src.rpm
For -13: ------------------------------------------------------ %{__ld} -shared -soname=libcgi-util.so.2 libcgi-util.o -o libcgi-util.so ------------------------------------------------------ - This cannot be accepted as http://koji.fedoraproject.org/koji/taskinfo?taskID=170767 Please check: http://www.redhat.com/archives/rhl-devel-list/2007-August/msg00481.html
Spec URL: http://flyn.org/SRPMS/cgi-util.spec SRPM URL: http://www.flyn.org/SRPMS/cgi-util-2.2.1-14.fc8.src.rpm
For -14: * To keep timestamp, please use "-p" option when using "install" or "cp" commands * From rpmlint: ------------------------------------------------- [tasaka1@localhost cgi-util]$ rpmlint *-14*rpm cgi-util.i386: E: no-ldconfig-symlink /usr/lib/libcgi-util.so.2.2.1 [tasaka1@localhost cgi-util]$ rpmlint -I no-ldconfig-symlink no-ldconfig-symlink : The package should not only include the shared library itself, but also the symbolic link which ldconfig would produce. (This is necessary, so that the link gets removed by rpm automatically when the package gets removed, even if for some reason ldconfig would not be run at package postinstall phase.) ------------------------------------------------- In short, symlink "libcgi-util.so.2" is missing.
Spec URL: http://flyn.org/SRPMS/cgi-util.spec SRPM URL: http://www.flyn.org/SRPMS/cgi-util-2.2.1-15.fc8.src.rpm
Okay. ------------------------------------------------------- This package (cgi-utils) is APPROVED by me -------------------------------------------------------