Spec URL: http://terjeros.fedorapeople.org/e16/e16-keyedit.spec SRPM URL: http://terjeros.fedorapeople.org/e16/e16-keyedit-0.5-1.fc8.src.rpm Description: e16keyedit provides a graphical interface for managing keybindings in Enlightenment, DR16.
e16 is in fedora now and license of e16 stuff is ok, see #254056. Updates package: spec: http://terjeros.fedorapeople.org/e16/e16-keyedit.spec srpm: http://terjeros.fedorapeople.org/e16/e16-keyedit-0.5-2.fc8.src.rpm
rpmlint clean. Why e16-keyedit and not e16keyedit? Just matching the existing packages? This should really have a .desktop file, and does not. https://fedoraproject.org/wiki/Packaging/Guidelines#desktop Otherwise, looks good on full review.
All e16 packages are named e16-*, however no big issue to rename this one to e16keyedit. Updated package: - Add desktop file spec: http://terjeros.fedorapeople.org/e16/e16-keyedit.spec srpm: http://koji.fedoraproject.org/koji/getfile?taskID=887831&name=e16-keyedit-0.5-3.fc11.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=887830
Koji build pruned, repost?
srpm: http://terjeros.fedorapeople.org/e16/e16-keyedit-0.5-3.fc9.src.rpm
Leave the name as is. Looks great. APPROVED.
Thanks! New Package CVS Request ======================= Package Name: e16-keyedit Short Description: GUI for editing keybindings for Enlightenment, DR16 Owners: terjeros Branches: F-8 F-9 InitialCC:
cvs done
Yeah! Closed after 13 months. Imported and built.