Bug 254188 - virt-install writes vncdisplay=<vncport> in domain config
Summary: virt-install writes vncdisplay=<vncport> in domain config
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: libvirt   
(Show other bugs)
Version: 5.1
Hardware: i386
OS: Linux
Target Milestone: ---
: ---
Assignee: Daniel Veillard
QA Contact: Virtualization Bugs
Keywords: Regression
Depends On:
TreeView+ depends on / blocked
Reported: 2007-08-24 17:09 UTC by Flavio Leitner
Modified: 2018-10-19 23:11 UTC (History)
2 users (show)

Fixed In Version: RHEA-2007-0643
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-11-07 17:27:16 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Patch to fix vncdisplay in domain config (864 bytes, application/octet-stream)
2007-08-24 17:09 UTC, Flavio Leitner
no flags Details

External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2007:0643 normal SHIPPED_LIVE libvirt enhancement update 2007-11-08 14:15:22 UTC

Description Flavio Leitner 2007-08-24 17:09:44 UTC
Description of problem:

virt-install writes vncdisplay=<vncport> in domain config when it should be
<vncport - 5900>.

Version-Release number of selected component (if applicable):

libvirt 0.2.3-8.el5

How reproducible:

Steps to Reproduce:

# virt-install --vnc --vncport=5920 --name=it128941 --vcpus=2 --ram=512
--file=/home/guests/it128941 --paravirt --location=

and check domain config:
vfb = [ "type=vnc,vncdisplay=5920" ]
Actual results:
vfb = [ "type=vnc,vncdisplay=5920" ]

Expected results:
vfb = [ "type=vnc,vncdisplay=20" ]

Code does:
     } else {
           strcat(val, ",vncdisplay=");
           strcat(val, (const char*)vncport);

it should do vncport - 5900.
Patch attached.

Comment 1 Flavio Leitner 2007-08-24 17:09:47 UTC
Created attachment 172440 [details]
Patch to fix vncdisplay in domain config

Comment 2 Daniel Veillard 2007-08-24 20:19:08 UTC
Okay, assuming the problem is confirmed (I didn't checked yet) why is
this of priority 'high' and 'urgent' ? Xen in 5.1 usually keep the
definitions of domains in a separate database, and that's what is used
when actually starting the domain or working with it.
Please explain the kind of problem it raised in practice, 


Comment 3 Flavio Leitner 2007-08-24 20:32:32 UTC
According with customer it works on RHEL5.0GA and fails on RHEL5.1 and they need
this fixed otherwise it's impossible to keep track of vncports/vncdisplay.

Comment 7 Issue Tracker 2007-08-27 16:38:38 UTC
Here is the reason why I escalated this issue as regression from EL5.0.
> If this doesn't occur on EL5.0GA, I can push this issue for 5.1 as the

This issue does not occur on RHEL5.0GA because the configuration file is
made by the virt-install command.
At RH5.1, that is made by libvirt.

So could you push this issue ?

Internal Status set to 'Waiting on Customer'
Status set to: Waiting on Client

This event sent from IssueTracker by mmatsuya 
 issue 128941

Comment 9 Daniel Veillard 2007-08-28 13:33:58 UTC
Problem reproduced, path fixes it:

[root@paphio ~]# virsh dumpxml test254188 | grep vnc
    <graphics type='vnc' port='5920'/>
[root@paphio ~]# grep vnc /etc/xen/test254188 
vfb = [ "type=vnc,vncdisplay=20" ]
[root@paphio ~]# rpm -q libvirt python-virtinst xen
[root@paphio ~]# 


Comment 12 Daniel Veillard 2007-08-29 14:15:54 UTC
built libvirt-0.2.3-9.el5 in dist-5E-qu-candidate with the fix,


Comment 17 errata-xmlrpc 2007-11-07 17:27:16 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.