Bug 257341 - Review Request: obexfs - FUSE based filesystem using ObexFTP
Summary: Review Request: obexfs - FUSE based filesystem using ObexFTP
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-08-27 18:36 UTC by Dominik 'Rathann' Mierzejewski
Modified: 2007-11-30 22:12 UTC (History)
2 users (show)

Fixed In Version: 0.11-0.1.rc2.fc7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-10-29 19:07:01 UTC
Type: ---
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Dominik 'Rathann' Mierzejewski 2007-08-27 18:36:32 UTC
Spec URL: http://rathann.fedorapeople.org/review/obexfs.spec
SRPM URL: http://rathann.fedorapeople.org/review/obexfs-0.11-0.1.rc2.fc7.src.rpm
Description:
The ObexFS driver is a wrapper for ObexFTP to provide filesystem access
to mobile phones.

Comment 1 Parag AN(पराग) 2007-08-28 04:00:02 UTC
FYI,
  on mock build i386 rawhide I saw
/builddir/build/BUILD/obexfs-0.11/missing: Unknown `--run' option
Try `/builddir/build/BUILD/obexfs-0.11/missing --help' for more information
configure: WARNING: `missing' script is too old or missing

This is not causing any problem for build.

Comment 2 Parag AN(पराग) 2007-08-28 04:03:41 UTC
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
e1dd69f43d734f3a3faa67a735ac68d4  obexfs-0.11-rc2.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Requires: libbfb.so.0 libbluetooth.so.2 libc.so.6 libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdl.so.2 libfuse.so.2
libfuse.so.2(FUSE_2.5) libmulticobex.so.1 libobexftp.so.0 libopenobex.so.1
libpthread.so.0 libpthread.so.0(GLIBC_2.0) librt.so.1 libusb-0.1.so.4 rtld(GNU_HASH)

+ Not a GUI app.

APPROVED.


Comment 3 Dominik 'Rathann' Mierzejewski 2007-08-29 00:11:50 UTC
New Package CVS Request
=======================
Package Name: obexfs
Short Description: FUSE based filesystem using ObexFTP
Owners: rathann
Branches: FC-6 F-7
InitialCC:
Cvsextras Commits: yes

Comment 4 Dominik 'Rathann' Mierzejewski 2007-08-29 00:12:37 UTC
Thanks for the quick review.

Comment 5 Kevin Fenzi 2007-08-29 01:28:35 UTC
cvs done.

Comment 6 Fedora Update System 2007-09-04 22:02:02 UTC
obexfs-0.11-0.1.rc2.fc7 has been pushed to the Fedora 7 testing repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Parag AN(पराग) 2007-09-19 06:58:22 UTC
is this built already? If yes then you can close this review request.

Comment 8 Dominik 'Rathann' Mierzejewski 2007-09-19 18:12:22 UTC
Yes, sorry.

Comment 9 Fedora Update System 2007-10-29 19:07:00 UTC
obexfs-0.11-0.1.rc2.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.