Bug 277891 - mount syscall should return error during remount of nfs share if options other then ro/rw present
mount syscall should return error during remount of nfs share if options othe...
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jeff Layton
Martin Jenner
Depends On:
Blocks: 425461
  Show dependency treegraph
Reported: 2007-09-05 03:19 EDT by Issue Tracker
Modified: 2010-10-22 14:24 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-04-10 15:56:48 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
proposed upstream patch (2.07 KB, patch)
2008-03-19 09:21 EDT, Jeff Layton
no flags Details | Diff

  None (edit)
Description Issue Tracker 2007-09-05 03:19:41 EDT
Escalated to Bugzilla from IssueTracker
Comment 1 Issue Tracker 2007-09-05 03:21:17 EDT
nfs does not define a remount_fs operation in its super_operations because
of which remount of nfs shares will not work for operations other then
generic mount options.

When we try to remount nfs shares with options such as actimeo, the option
is not applied. But the mount syscall in these cases returns a success.

The customer requests that if options which are not going to be effective
are passed when remounting nfs shares, the operation should fail and an
error propagated to the userland mount command. The current setup causes
problems when the new mount options are written to the mtab file even
though the options are  not effective and the mount -v cannot be trusted.
The customer in such cases has to grep through /proc/mounts to see if the
command succeded.    

"mount" should return a non-zero exit code if anything didn't work when
attempting to perform the requested actions.

It looks like this will require us to add a remount_fs opetation to
nfs_sops. This doesn't seem to exist upstream.

This event sent from IssueTracker by sprabhu 
 issue 126915
Comment 4 RHEL Product and Program Management 2007-09-07 11:17:57 EDT
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
Comment 6 Jeff Layton 2007-11-20 10:55:42 EST
actually...this doesn't look too tough to implement upstream (or for RHEL5). We
already have a nfs_compare_mount_options() function that tells us if there are
different options.

I suppose we can just wrap that and have remount_fs error out if that function
returns false. I'm not sure what error is appropriate in this situation though.

Still, it's not likely that this will go upstream before the 5.2 deadline so 5.3
is probably appropriate...
Comment 8 Jeff Layton 2007-11-20 13:00:18 EST
It's a little trickier than that though...

It appears that mount.nfs doesn't fully populate the nfs_mount_data structure on
a remount. In particular, things like the address and family are missing. This
might not a problem for text based mounts, but fedora doesn't have those yet.

...so to fix this right, we'll probably have to fix mount.nfs too, or break up
the comparison functions so that the missing info isn't needed.

Comment 9 Jeff Layton 2008-03-19 09:21:35 EDT
Created attachment 298503 [details]
proposed upstream patch

Proposed upstream patch for this. Just have all remount attempts fail with

I was considering trying to compare mount options and allowing it to succeed if
none had changed, but that turns out to be pretty complex and I'm not sure
there's much value in it.
Comment 10 Jeff Layton 2008-04-10 15:21:15 EDT
The patch in comment #9 was shot down by the upstream maintainer. It would make
it so that mounting with '-o ro,remount' would fail when it currently would succeed.

There are significant problems with making this work, however, particularly with
binary mount options which are what is used in RHEL4 and 5.

For instance, suppose we have a mount with options like this:


...and then I come along and do this:

mount -o remount,ro ...

...mount.nfs will fill out a new option struct and will leave rsize blank (since
I didn't specify it). If I then compare my new mount options with the existing
ones, they'll appear to be different (since my old rsize was non-default), and
the mount would have to be denied.

For this reason, I'm going to devel_nak this case. I don't think it's feasible
that we can actually do this in any existing RHEL release while maintaining ABI. 

RHEL6 and beyond should have string-based mount options. With that, this may be
more feasible, though userspace mount.nfs will need to be able to parse
/proc/mounts or /etc/mtab and merge the existing mount options with any
specified on the command line.
Comment 11 RHEL Product and Program Management 2008-04-10 15:56:48 EDT
Development Management has reviewed and declined this request.  You may appeal
this decision by reopening this request. 

Note You need to log in before you can comment on or make changes to this bug.