Spec URL: http://zprikryl.fedorapeople.org/linuxdcpp.spec SRPM URL: http://zprikryl.fedorapeople.org/linuxdcpp-1.20070905cvs-1.src.rpm Description: Linux DC++ is a program the uses the Direct Connect protocol. It is compatible with other DC clients, such as the original DC from Neomodus, DC++ and derivatives. Linux DC++ also interoperates with all common DC hub software.
You need to provide instructions in the spec how to create the tarball, see: http://fedoraproject.org/wiki/Packaging/SourceURL#head-615f6271efb394ab340a93a6cf030f2d08cf0d49 instead of scons PREFIX=/usr you should use scons PREFIX=%{_prefix} The cvs Tag should be in release, see: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-d97a3f40b6dd9d2288206ac9bd8f1bf9b791b22a A good value for version would be imho 0, to make sure there are no conflicts, once upstream uses a versioning schema
I correct those errors. Spec URL: http://zprikryl.fedorapeople.org/linuxdcpp.spec SRPM URL: http://zprikryl.fedorapeople.org/linuxdcpp-0-0.1.20070905cvs.src.rpm Description: Linux DC++ is a program the uses the Direct Connect protocol. It is compatible with other DC clients, such as the original DC from Neomodus, DC++ and derivatives. Linux DC++ also interoperates with all common DC hub software.
I will review it now completely. Here is a little hint: Do not write the release in the 0.1 from the release in the tarball oder directory. Otherwise you will have to rebuild the tarball everytime to only want to increase the release without changing the tarball, e.g. due to Requires-adjustment oder because of a mandatory rebuild.
- rpmlint: NEEDSWORK W: linuxdcpp rpm-buildroot-usage %build scons PREFIX=%{_prefix} FAKE_ROOT=$RPM_BUILD_ROOT release=0 It seems you can skip FAKE_ROOT=$RPM_BUILD_ROOT in %build, than rpmlint will be silent. I do not know scons, but SConstruct uses FAKE_ROOT only in its install section. - licenses: NEEDSWORK You used GPLv2 in License, but when I look in the source, nearly every file hast a GPLv2+ header. - naming: ok - license in %doc: ok - spec legible: ok - compiling:builds for all supported architectures:ok - BuildRequires: ok - locales: not used: ok - ldconfig: not needed: ok - directory ownage: ok, todo Please use %{_datadir}/linuxdcpp/ in %files to make it visible, that it is a directory - %clean, %install rm -rf: ok - BuildRoot: ok - no -devel or -static subpackage: ok TODO (by me): - Verify .desktop file I do not yet know, how to verify whether or not StartupNotify and/or StartupWMClass should be used. I have to do some research here. - Verify tarball creation
* Fedora specific compilation flags are not honored correctly http://koji.fedoraproject.org/koji/getfile?taskID=152384&name=build.log So the created debuginfo rpm is incomplete * Categories "Application X-Fedora" in fedora-linuxdcpp.desktop are deprecated and should be removed. * rpmlint: linuxdcpp.i386: W: file-not-utf8 /usr/share/doc/linuxdcpp-0/Changelog.txt linuxdcpp.i386: W: file-not-utf8 /usr/share/doc/linuxdcpp-0/Credits.txt Encoding should be UTF-8.
Hello, I corrected all reported errors above. Spec URL: http://zprikryl.fedorapeople.org/linuxdcpp.spec SRPM URL: http://zprikryl.fedorapeople.org/linuxdcpp-0-0.1.20070905cvs.src.rpm Description: Linux DC++ is a program the uses the Direct Connect protocol. It is compatible with other DC clients, such as the original DC from Neomodus, DC++ and derivatives. Linux DC++ also interoperates with all common DC hub software.
Sorry, I have a lot of headaches recently, so I do not know when I will feel good enough to review this. If someone else wants to review this, please do. When I am healthy again, I will review this, in case it still needs a review.
This is a duplicate of bug #234331
*** This bug has been marked as a duplicate of 234331 ***