Spec URL: http://www.salstar.sk/pub/fedora/SPECS/aspell-sk.spec SRPM URL: http://www.salstar.sk/pub/fedora/SRPMS/7/aspell-sk-0.52-2.fc7.src.rpm Description: Provides the word list/dictionaries for the following: Slovak This is an Slovak dictionary for aspell. Why aspell dictionaries are binary and not "noarch" packages? Rpmlint is not happy with this. Is it OK or I need to update my package?
Hello Ondej, I will review this request this week. Thank you for submitting.
Transferring to my colleague Ivana after agreement. She's our aspell guru :)
Good work :), it is almost error free, I found only three problems which should be fixed before the review flag will be granted: * There is necessary to have aspell >= 12:0.60 because of there is incompatibility between world lists generated with aspell 0.52 and 0.60 (and there is necessary to add epoch tag) * There should be set debug_package to %{nil} - it prevents to create empty debuginfo package * I'm not sure why there is mv configure reconfigure ./reconfigure I'm not sure why there is not used only ./configure That's all.
OK, thanks for review. Things updated. The configure is updated as "sh configure" without rename to be rpmlint quiet. * Thu Sep 06 2007 Jan ONDREJ (SAL) <ondrejj(at)salstar.sk> - 0.52-3 - changed requirement to aspell >= 12:0.60 because of there worldlist incompatibility - debug_package set to nil to prevent empty debuginfo package - configure is called with sh interpreter to prevent rpmlint errors New package: http://www.salstar.sk/pub/fedora/SRPMS/7/aspell-sk-0.52-3.fc7.src.rpm spec file URL has been not changed, only content updated. There are still rpmlint errors: E: aspell-sk no-binary E: aspell-sk only-non-binary-in-usr-lib but they are on all aspell-LANG packages. May be all of them need to be set as "noarch" packages. What do you think? Depend they on different architectures?
Yes this package is arch dependent due to the world-list directory transformation (which is realize during the make phase). This errors are OK, there is no problem with them. Looks fine for me. APPROVED
New Package CVS Request ======================= Package Name: aspell-sk Short Description: Slovak dictionaries for Aspell Owners: ondrejj Branches: FC-6 F-7 EL-4 EL-5 InitialCC: ondrejj Cvsextras Commits: yes
cvs done.
Package built for FC6, F7, F8 (devel) and EL5. Unable to build for EL4 according to dependency problems.
Requested push to Fedora 7 repository on Bodhi. Do I need a special request to push this package to FE-6 and EPEL? They have been compiled, but they are in needsign state: http://buildsys.fedoraproject.org/build-status/job.psp?email=ondrejj@salstar.sk&uid=36195 http://buildsys.fedoraproject.org/build-status/job.psp?email=ondrejj@salstar.sk&uid=36197 EL4 package build failed due to dependencies. Can I request branch removal?