Bug 28072 - anaconda's loader.c has incorrect umount() call
Summary: anaconda's loader.c has incorrect umount() call
Status: CLOSED RAWHIDE
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: anaconda
Version: 7.0
Hardware: i386
OS: Linux
medium
low
Target Milestone: ---
Assignee: Erik Troan
QA Contact: Brock Organ
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2001-02-17 01:37 UTC by Jim Wright
Modified: 2007-04-18 16:31 UTC (History)
0 users

(edit)
Clone Of:
(edit)
Last Closed: 2001-02-20 19:33:34 UTC


Attachments (Terms of Use)

Description Jim Wright 2001-02-17 01:37:54 UTC
From Bugzilla Helper:
User-Agent: Mozilla/4.75 [en] (X11; U; Linux 2.2.16-22 i686)


In loader/loader.c, the following code appears:

    mlLoadModule("nfs", NULL, modLoaded, *modDepsPtr, NULL, NULL, flags);

    if (doPwMount(ksPath, "/tmp/nfskd", "nfs", 1, 0, NULL, NULL)) {
        logMessage("failed to mount %s", ksPath);
        return 1;
    }

    fullFn = malloc(strlen(file) + 20);
    sprintf(fullFn, "/tmp/nfskd/%s", file);
    copyFile(fullFn, location);

    umount("/tmp/nfs");

The last line should be

    umount("/tmp/nfskd");


Reproducible: Always
Steps to Reproduce:
1. do a kickstart install using a config file on an nfs server

	

Actual Results:   notice that /tmp/nfskd does not get unmounted


Expected Results:   /tmp/nfskd should be unmounted after the kickstart
config file is copied

Comment 1 Erik Troan 2001-02-20 20:30:07 UTC
<blush> Fixed.

Comment 2 Glen Foster 2001-03-02 18:05:34 UTC
Our installer team-lead thinks we should really fix this before next release.


Note You need to log in before you can comment on or make changes to this bug.