Spec URL: http://people.atrpms.net/~hdegoede/TnL.spec SRPM URL: http://people.atrpms.net/~hdegoede/TnL-070909-1.fc8.src.rpm Description: Thunder&Lightning is a futuristic action flight simulator game that takes place in a large 3D environment. Jump into the pilot seat of your Lightning aircraft and fight against Thunder tanks in a fierce battle for control of the island! In the long run, Thunder&Lightning will incorporate features from the 80's classics Carrier Command and Midwinter. There will be multiple Islands to conquer, each with its own defense strategy. Thunder&Lightning will not be mission oriented, but there will be scripted events for each island. --- Reviewers note this package requires TnL-data whos review is bug 290421.
* rpmlint: NO PROBLEMS * Package named correctly: YES * Patches named correctly: YES * Spec file named correctly: YES * Licence(s) acceptable: YES * Licence field matches: YES * Licence file installed: YES (OK as included upstream) * Spec file in American English: YES * Source matches upstream: YES * Locales use %find_lang: N/A * Contains %clean: YES * %install contain rm -rf %{buildroot} or similar: YES * Specfile legible: YES * Compiles and builds ok: NO [!! See below] * Calls ldconfig in %post/%postun for shlibs: N/A * Owns directories it creates: YES * Duplicate files: NO * Permissions set correctly: YES * Consistent macro use: NO [!! See below] * Separate -doc needed (for large docs): NO (no large docs) * %doc affects runtime: NO * Headers and static libs in -devel: N/A * .pc files in -devel: N/A * .so in -devel: N/A * -devel requires base: N/A * Contains .la files: NO * Owns files it didn't create: NO * .desktop files included and installed correctly: YES * Filenames valid UTF8: YES 1. Macro use could improved by using %{name} on the source line and requires line to be consistent with your use elsewhere. 2. Does not compile properly due to missing buildrequires. You seem to be missing boost-devel It's worth mentioning but it segfaults for me on startup if /dev/dsp is in use. Otherwise it starts up correctly.
Just noticed too, "non standard" buildroot. You should probably change this to: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Wed Oct 3 2007 Hans de Goede <j.w.r.degoede> 070909-2 - Use %{name} everywhere for consistency - Add missing boost-devel BuildRequires - Exit gracefully when the game cannot open the soundcard - Use opengl-games-utils wrapper to show error dialog when DRI is missing Spec URL: http://people.atrpms.net/~hdegoede/TnL.spec SRPM URL: http://people.atrpms.net/~hdegoede/TnL-070909-1.fc8.src.rpm
(In reply to comment #3) > SRPM URL: http://people.atrpms.net/~hdegoede/TnL-070909-1.fc8.src.rpm The URL is incorrect but I pulled down what I assume to be the right RPM. The buildroot hasn't been changed, please fix that before import. Package APPROVED!
Thanks! New Package CVS Request ======================= Package Name: TnL Short Description: Thunder & Lightning - A futuristic action flight simulator game Owners: jwrdegoede Branches: F-7 devel InitialCC: <empty> Cvsextras Commits: Yes
done.
Imported and build, closing.