Spec URL: http://people.atrpms.net/~hdegoede/ladspa-amb-plugins.spec SRPM URL: http://people.atrpms.net/~hdegoede/ladspa-amb-plugins-0.3.0-1.fc8.src.rpm Description: A set of first order Ambisonics plugins I use with Ardour. Included are: mono and stereo input panner, horizontal rotation, and square and hexagon horizontal decoders. See the README for more.
Typo in the "amb-plugins" Provides: $ rpm -qp --provides /home/qa/tmp/rpm/RPMS/ladspa-amb-plugins-0.3.0-1.fc8.i386.rpm amb-plugins = 0.3.0=1.fc8 ambisonic1.so ambisonic2.so ladspa-amb-plugins = 0.3.0-1.fc8 Suggesting you replace 'I use' with 'to use' in the %description With the Provides in the Obsoletes/Provides pair you practically occupy the "amb-plugins" namespace. Is this really necessary to keep both package names when this is a new-entry in Fedora? Else it's approved packaging- and licencing-wise.
(In reply to comment #1) > Typo in the "amb-plugins" Provides: > This will be fixed in the imported version > Suggesting you replace 'I use' with 'to use' in the %description Idem > > With the Provides in the Obsoletes/Provides pair you practically > occupy the "amb-plugins" namespace. Is this really necessary > to keep both package names when this is a new-entry in Fedora? > The obsoletes is necessary because it used to be called amb-plugins in somewhat older but not very old CCRMA releases, the provides is there as upstream's name is amb-plugins and thus IMHO yum install amb-plugins should work too.
New Package CVS Request ======================= Package Name: ladspa-amb-plugins Short Description: Ambisonics LADSPA plugins Owners: jwrdegoede nando Branches: F-7 devel InitialCC: <empty> Cvsextras Commits: Yes
cvs done.
Michael, thanks for the review! Imported and build, update push requested for F-7, closing.