Bug 293761 - hal-info incorrectly lists Thinkpad T61
Summary: hal-info incorrectly lists Thinkpad T61
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: hal-info
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: David Zeuthen
QA Contact: Fedora Extras Quality Assurance
URL: http://lists.freedesktop.org/archives...
Whiteboard:
Depends On:
Blocks: F8Target
TreeView+ depends on / blocked
 
Reported: 2007-09-17 19:26 UTC by Michel Lind
Modified: 2013-03-06 03:52 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2007-10-09 15:08:01 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch to correct identification of Thinkpad T61 (512 bytes, patch)
2007-09-17 19:26 UTC, Michel Lind
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
FreeDesktop.org 12462 0 None None None Never

Description Michel Lind 2007-09-17 19:26:29 UTC
Description of problem:
The above URL identifies a patch submission that has been merged in, and is
present in Fedora's hal-info. It is buggy:

- the submitter uses his system.hardware.product string, 766314G, which 
  does not uniquely identify the T61 (mine is 7658CTO)
- furthermore, the patch incorrectly uses 'system.hardware.version' rather than
  'system.hardware.product'

Please find attached a patch that changes the Lenovo quirk file so that it keys
in on system.hardware.product="Thinkpad T61" instead.

Version-Release number of selected component (if applicable):
hal-info-20070725-1.fc8

How reproducible:
Always


Steps to Reproduce:
1. Suspend
2. Resume
  
Actual results:
Backlight not re-enabled

Expected results:
Backlight re-enabled

Additional info:

Comment 1 Michel Lind 2007-09-17 19:26:29 UTC
Created attachment 197741 [details]
Patch to correct identification of Thinkpad T61

Comment 2 Michel Lind 2007-09-17 19:54:46 UTC
Note that with the current Rawhide kernel, the modification allows the laptop to
suspend, but now it won't resume -- might be a kernel problem. Without s3_mode
the laptop will wake up immediately (and backlight is off); with s3_bios the
laptop will wake up immediately and the backlight is reenabled.

Comment 3 David Zeuthen 2007-10-09 15:08:01 UTC
This is wrong; IIRC a Thinkpad T61 can come with different video cards and then
you need different quirks. Btw, in the future please send patches to the hal
list instead of RH Bugzilla. Thanks!

Comment 4 Michel Lind 2007-10-10 16:59:20 UTC
I did list the upstream bug entry as well, but sorry for the duplication.

Good point that T61 comes with different video cards, but the entry I referred
to is still wrong: instead of s.h.v it should have said s.h.p (version is just
"Thinkpad T61", it's the product key that has the different product numbers)



Note You need to log in before you can comment on or make changes to this bug.