Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 295151

Summary: The "in" operator to pam_succeed_if appears to be broken
Product: Red Hat Enterprise Linux 5 Reporter: John T. Rose <inode0>
Component: pamAssignee: Tomas Mraz <tmraz>
Status: CLOSED ERRATA QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: 5.0CC: mmalik
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: RHBA-2008-0336 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-05-21 17:27:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Possible pam_succeed_if.c patch to actually search lists for matches none

Description John T. Rose 2007-09-18 17:33:38 UTC
Description of problem:

consider an entry like

auth sufficient /lib/security/$ISA/pam_succeed_if.so user in redhat:hat

this will succeed for user redhat and fail for user hat

switching these around like

auth sufficient /lib/security/$ISA/pam_succeed_if.so user in hat:redhat

will succeed for both user redhat and for user hat

Version-Release number of selected component (if applicable):

appears broken on both rhel4 and rhel5 (didn't check anything older than that)

How reproducible:

should be obvious from above description

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

take a look at the evaluate_inlist() function in pam_succeed_if.c and the cause
should be fairly easy to see

Comment 1 John T. Rose 2007-09-23 16:16:01 UTC
Here is a patch that seems to fix this for my case ... not sure about all other
possible uses of the operator...

Comment 2 John T. Rose 2007-09-23 16:18:33 UTC
Created attachment 203531 [details]
Possible pam_succeed_if.c patch to actually search lists for matches

Comment 3 RHEL Program Management 2007-10-19 20:26:05 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 8 errata-xmlrpc 2008-05-21 17:27:09 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2008-0336.html


Comment 9 Chris Ward 2008-06-17 15:48:42 UTC
Reminder: This bug includes the 'RHTS' QA Whiteboard Keyword. Don't forget to add
'RHTSdone' to the QA Whiteboard along with a comment describing where the RHTS
test can be found once the RHTS test has been written. Otherwise, if an RHTS
will not be created, please remove RHTS from the qa whiteboard.