Bug 301571 - Review Request: opengl-games-utils - Utilities to check proper 3d support before launching 3d games
Summary: Review Request: opengl-games-utils - Utilities to check proper 3d support bef...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dan Horák
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-09-22 09:26 UTC by Hans de Goede
Modified: 2007-11-30 22:12 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-10-09 15:12:22 UTC
Type: ---
Embargoed:
dan: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Hans de Goede 2007-09-22 09:26:56 UTC
Spec URL: http://people.atrpms.net/~hdegoede/opengl-games-utils.spec
SRPM URL: http://people.atrpms.net/~hdegoede/opengl-games-utils-0.1-1.fc8.src.rpm
Description:
This package contains various shell scripts which are intented for use by
3D games packages. These shell scripts can be used to check if direct rendering
is available before launching an OpenGL game. This package is intended for use
by other packages and is not intended for direct end user use!

Comment 1 Dan Horák 2007-09-22 10:06:44 UTC
formal review is here:

OK	source files match upstream as it is upstream (packager = author)
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible. License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	%clean is present.
OK	package builds in mock (development/i386).
OK	rpmlint is silent.
OK	final provides and requires look sane
OK	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates (in fact there are none).
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	no scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	not a GUI app.

this package is APPROVED


Comment 2 Hans de Goede 2007-09-22 13:29:36 UTC
Thanks!

New Package CVS Request
=======================
Package Name:      opengl-games-utils
Short Description: Utilities to check proper 3d support before launching 3d games
Owners:            jwrdegoede
Branches:          F-7 devel
InitialCC:         <empty>
Cvsextras Commits: yes


Comment 3 Kevin Fenzi 2007-09-24 16:18:22 UTC
cvs done.

Comment 4 Hans de Goede 2007-09-24 18:30:00 UTC
Imported and build, closing.


Comment 5 Hans de Goede 2007-10-09 15:12:22 UTC
Oops, forgot to close.


Note You need to log in before you can comment on or make changes to this bug.