Spec URL: http://odysseus.x-tnd.be/fedora/php-pear-MDB2-Driver-mysqli/php-pear-MDB2-Driver-mysqli.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-pear-MDB2-Driver-mysqli/php-pear-MDB2-Driver-mysqli-1.4.1-1.fc7.src.rpm Description: This is the MySQL Improved MDB2 driver
REVIEW: * rpmlint : W: no-documentation * The package is named according to the Package Naming Guidelines. * The spec file name match the base package * The package must the PHP Packaging Guidelines * Fedora approved license (BSD) * License field in the package spec file match the actual license * The spec file is written in American English * The spec file is legible * The sources used to build the package must match the upstream source eb93eb4687da1a1018c832622da42f6f MDB2_Driver_mysqli-1.4.1.tgz * build in mock (F-7, noarch) * All build dependencies are listed in BuildRequires * no locales * no shared library files * package own all directories that it creates * Package don't own files or directories already owned by other packages * no duplicate files * Permissions on files are set properly * %clean section * package consistently use macros * The package contain code * no documentation * no library * no desktop file * %install, start with rm -rf %{buildroot} * All filenames are valid UTF-8 * scriptlets are sane* * Final Provides ok php-pear(MDB2_Driver_mysqli) = 1.4.1 php-pear-MDB2-Driver-mysqli = 1.4.1-1.fc8 * Final Requires see below /usr/bin/pear php-pear(MDB2) >= 2.3.0 php-pear(PEAR) Tests run (after installation/configuration as usually) but with some errors that should probably be reported upstream (case problem in table name (win32) p.e.) MUST : Requires php-pear(MDB2) >= 2.4.1 according to upstream
Thanks for your review :-) * rpmlint : W: no-documentation Upstream does not provide any documentation for this package Pear::MDB2 required version is fixed, news URLs are : Spec URL: http://odysseus.x-tnd.be/fedora/php-pear-MDB2-Driver-mysqli/php-pear-MDB2-Driver-mysqli.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-pear-MDB2-Driver-mysqli/php-pear-MDB2-Driver-mysqli-1.4.1-2.fc7.src.rpm
* Final Requires OK /usr/bin/pear php-pear(MDB2) >= 2.4.1 php-pear(PEAR) APPROVED.
Please add a CVS template here so we know what branches you want, etc. See: http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure Reset the fedora-cvs flag to ? when you are ready.
Ooops, sorry, here it is. New Package CVS Request ======================= Package Name: php-pear-MDB2-Driver-mysqli Short Description: This is the MySQL Improved MDB2 driver Owners: trasher Branches: F-7 InitialCC: trasher Cvsextras Commits: yes
CVS done.
Package Change Request ====================== Package Name: php-pear-MDB2-Driver-mysqli New Branches: EL-6 Owners: trasher
CVS Done