Description of problem:

When installing a rpm that requires space on a filesystem with 0 blocks free,
rpm will not detect that there is insufficient space on the filesystem.

Version-Release number of selected component (if applicable):

The problem was discovered with version rpm-4.4.2-15.2.  I looked at a newer
version of the source (rpm-4.4.2-46).  The newer version still appears to have
the same problem.

How reproducible:

100%

Steps to Reproduce:
1. copy an rpm to test machine
2. fill up filesystem that the rpm needs (ex. cat /dev/zero >> /usr/local/foo)
   ensure there are 0 blocks free (df /usr/local)
3. attempt to install the rpm
   rpm -i <rpm-file>
  
Actual results:

% rpm -i foo.i386.rpm 
error: unpacking of archive failed on file /usr/local/foo.txt;46fc1caa: cpio:
write failed - No space left on device

Expected results:

[root@secfi tmp]# rpm -i foo.i386.rpm 
        installing package foo needs XXXMB on the /usr/local filesystem


Additional info:

The problem appears to be with the function rpmtsCheckDSIProblems()
in lib/rpmts.c.

Here is a suggested diff:

--- a/rpm-4.4.2/lib/rpmts.c     2007-09-26 16:11:00.000000000 -0600
+++ b/rpm-4.4.2/lib/rpmts.c     2007-09-26 16:12:14.000000000 -0600
@@ -1354,14 +1354,14 @@
     ps = rpmtsProblems(ts);
     for (i = 0; i < ts->filesystemCount; i++, dsi++) {
 
-       if (dsi->bavail > 0 && adj_fs_blocks(dsi->bneeded) > dsi->bavail) {
+       if (dsi->bavail >= 0 && adj_fs_blocks(dsi->bneeded) > dsi->bavail) {
            rpmpsAppend(ps, RPMPROB_DISKSPACE,
                        rpmteNEVR(te), rpmteKey(te),
                        ts->filesystems[i], NULL, NULL,
           (adj_fs_blocks(dsi->bneeded) - dsi->bavail) * dsi->bsize);
        }
 
-       if (dsi->iavail > 0 && adj_fs_blocks(dsi->ineeded) > dsi->iavail) {
+       if (dsi->iavail >= 0 && adj_fs_blocks(dsi->ineeded) > dsi->iavail) {
            rpmpsAppend(ps, RPMPROB_DISKNODES,
                        rpmteNEVR(te), rpmteKey(te),
                        ts->filesystems[i], NULL, NULL,