Red Hat Bugzilla – Bug 308251
Review Request: lybniz - A function graph plotter
Last modified: 2007-11-30 17:12:16 EST
Spec URL: http://www.diffingo.com/downloads/diffingo-repo/lybniz/lybniz-1.3-1.fc8.src.rpm SRPM URL: http://www.diffingo.com/downloads/diffingo-repo/lybniz/lybniz.spec Description: Lybniz is an easy to use mathematical function graph plotter using PyGTK.
Need some updates in SPEC 1) Source URL should be http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz 2) You can use --delete-original in desktop-file-install command and remove following line rm -f ${RPM_BUILD_ROOT}%{_datadir}/applications/%{name}.desktop 3)rpmlint on SRPM gave me lybniz.src: W: strange-permission lybniz-startup.sh 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. 4) I don't see any use of CFLAGS. You can remove it.
Made the changes - Here's the updated pacakge: Spec URL: http://www.diffingo.com/downloads/diffingo-repo/lybniz/lybniz-1.3-2.fc8.src.rpm SRPM URL: http://www.diffingo.com/downloads/diffingo-repo/lybniz/lybniz.spec
Source URL is not working. Actually it should be Source0: http://downloads.sourceforge.net/lybniz2/%{name}-%{version}.tar.gz
installed package but desktop file is not working as Exec=lybniz.py is not in installed path and actual main executable program is lybniz so it should be Exec=lybniz
Done - Updated package: Spec URL: http://www.diffingo.com/downloads/diffingo-repo/lybniz/lybniz-1.3-3.fc8.src.rpm SRPM URL: http://www.diffingo.com/downloads/diffingo-repo/lybniz/lybniz.spec
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 6cb01766fb627a5046d482645c69f39a lybniz-1.3.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Desktop file handled correctly. + Package lybniz-1.3-3.fc8 -> Requires: /bin/sh /usr/bin/python pygtk2 >= 2.6 python >= 2.4 + GUI app. APPROVED.
Please check the ownership of %{_datadir}/%{name}/ .
How come my eyes missed that? Looks I should take a rest for day now. Stewart, Change %files section line from %{_datadir}/%{name}/* to %{_datadir}/%{name}
This is done in http://www.diffingo.com/downloads/diffingo-repo/lybniz/lybniz-1.3-3.fc8.src.rpm
New Package CVS Request ======================= Package Name: lybniz Short Description: A function graph plotter Owners: firewing Branches: FC-6 F-7 InitialCC: firewing Cvsextras Commits: yes
I assume you did that change in http://www.diffingo.com/downloads/diffingo-repo/lybniz/lybniz-1.3-4.fc8.src.rpm * issue got solved. * mock build is successful But this new SPEC gave now rpmlint warning lybniz.noarch: W: incoherent-version-in-changelog 4.82-4 1.3-4.fc7 The last entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. Before cvs-import, remember to correct changelog version.
cvs done.
Built - Thanks for the review!