Bug 313271 (perl-Net-IRC) - Review Request: perl-Net-IRC - Perl interface to the Internet Relay Chat protocol
Summary: Review Request: perl-Net-IRC - Perl interface to the Internet Relay Chat prot...
Status: CLOSED NEXTRELEASE
Alias: perl-Net-IRC
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-09-30 19:20 UTC by Christopher Stone
Modified: 2008-05-30 19:22 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2007-10-05 02:23:22 UTC
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Christopher Stone 2007-09-30 19:20:18 UTC
Spec URL: http://tkmame.retrogames.com/fedora-extras/perl-Net-IRC.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/perl-Net-IRC-0.75-1.fc7.src.rpm

Description:
Perl implementation of the IRC protocol (RFC 1459).

Comment 1 Parag AN(पराग) 2007-10-01 01:23:10 UTC
picking this for review.

Comment 2 Parag AN(पराग) 2007-10-01 01:40:17 UTC
you can install irctest and t under %doc. 
That additionally needs you to "chmod 644 irctest" in %prep section.


Comment 3 Christopher Stone 2007-10-01 22:52:47 UTC
Spec URL: http://tkmame.retrogames.com/fedora-extras/perl-Net-IRC.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/perl-Net-IRC-0.75-2.fc7.src.rpm

%changelog
* Mon Oct 01 2007 Christopher Stone <chris.stone@gmail.com> 0.75-2
- Add irctest and t/ to %%doc


Comment 4 Parag AN(पराग) 2007-10-02 02:02:20 UTC
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
57587a48ddece7a995c6b138003ee798  Net-IRC-0.75.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/01_minimal....ok
All tests successful.
Files=1, Tests=3,  0 wallclock secs ( 0.08 cusr +  0.01 csys =  0.09 CPU)
+ exit 0
+ Package perl-Net-IRC-0.75-2.fc8 -> 
  Provides: perl(Net::IRC) = 0.75 perl(Net::IRC::Connection) perl(Net::IRC::DCC)
perl(Net::IRC::DCC::Accept) perl(Net::IRC::DCC::CHAT)
perl(Net::IRC::DCC::Connection) perl(Net::IRC::DCC::GET)
perl(Net::IRC::DCC::SEND) perl(Net::IRC::Event) perl(Net::IRC::EventQueue)
perl(Net::IRC::EventQueue::Entry) 
  Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(IO::File)
perl(IO::Select) perl(IO::Socket) perl(IO::Socket::INET)
perl(Net::IRC::Connection) perl(Net::IRC::DCC) perl(Net::IRC::Event)
perl(Net::IRC::EventQueue) perl(Net::IRC::EventQueue::Entry) perl(Socket)
perl(Symbol) perl(strict) perl(subs) perl(vars) perl(warnings)

APPROVED.

Comment 5 Christopher Stone 2007-10-03 14:00:45 UTC
New Package CVS Request
=======================
Package Name: perl-Net-IRC
Short Description: Perl interface to the Internet Relay Chat protocol
Owners: xulchris
Branches: FC-6 F-7
InitialCC:
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2007-10-04 02:42:46 UTC
cvs done.

Comment 7 Christopher Stone 2007-10-05 02:23:22 UTC
Pushed to all branches.  Thanks for the review! :)

Comment 8 Christopher Stone 2008-05-29 17:04:49 UTC
Package Change Request
======================
Package Name: perl-Net-IRC
New Branches: EL-5

Comment 9 Kevin Fenzi 2008-05-30 19:22:55 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.