Red Hat Bugzilla – Bug 313271
Review Request: perl-Net-IRC - Perl interface to the Internet Relay Chat protocol
Last modified: 2008-05-30 15:22:55 EDT
Spec URL: http://tkmame.retrogames.com/fedora-extras/perl-Net-IRC.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/perl-Net-IRC-0.75-1.fc7.src.rpm Description: Perl implementation of the IRC protocol (RFC 1459).
picking this for review.
you can install irctest and t under %doc. That additionally needs you to "chmod 644 irctest" in %prep section.
Spec URL: http://tkmame.retrogames.com/fedora-extras/perl-Net-IRC.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/perl-Net-IRC-0.75-2.fc7.src.rpm %changelog * Mon Oct 01 2007 Christopher Stone <chris.stone@gmail.com> 0.75-2 - Add irctest and t/ to %%doc
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 57587a48ddece7a995c6b138003ee798 Net-IRC-0.75.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01_minimal....ok All tests successful. Files=1, Tests=3, 0 wallclock secs ( 0.08 cusr + 0.01 csys = 0.09 CPU) + exit 0 + Package perl-Net-IRC-0.75-2.fc8 -> Provides: perl(Net::IRC) = 0.75 perl(Net::IRC::Connection) perl(Net::IRC::DCC) perl(Net::IRC::DCC::Accept) perl(Net::IRC::DCC::CHAT) perl(Net::IRC::DCC::Connection) perl(Net::IRC::DCC::GET) perl(Net::IRC::DCC::SEND) perl(Net::IRC::Event) perl(Net::IRC::EventQueue) perl(Net::IRC::EventQueue::Entry) Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(IO::File) perl(IO::Select) perl(IO::Socket) perl(IO::Socket::INET) perl(Net::IRC::Connection) perl(Net::IRC::DCC) perl(Net::IRC::Event) perl(Net::IRC::EventQueue) perl(Net::IRC::EventQueue::Entry) perl(Socket) perl(Symbol) perl(strict) perl(subs) perl(vars) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-Net-IRC Short Description: Perl interface to the Internet Relay Chat protocol Owners: xulchris Branches: FC-6 F-7 InitialCC: Cvsextras Commits: yes
cvs done.
Pushed to all branches. Thanks for the review! :)
Package Change Request ====================== Package Name: perl-Net-IRC New Branches: EL-5