Bug 313681
| Summary: | O_ATOMICLOOKUP vs O_CLOEXEC(mainstream kernels) incompatibility | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Vasily Averin <vvs> |
| Component: | kernel | Assignee: | Michal Schmidt <mschmidt> |
| Status: | CLOSED DUPLICATE | QA Contact: | Martin Jenner <mjenner> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 5.1 | CC: | dzickus, esandeen, khorenko |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-12-05 13:58:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 358661 | ||
| Bug Blocks: | |||
|
Description
Vasily Averin
2007-10-01 10:58:26 UTC
btw I've found dentry leak in do_lookup():
fs/namei.c::
static int do_lookup(struct nameidata *nd, struct qstr *name,
struct path *path, int atomic)
{
struct vfsmount *mnt = nd->mnt;
struct dentry *dentry = __d_lookup(nd->dentry, name);
if (!dentry)
goto need_lookup;
if (dentry->d_op && dentry->d_op->d_revalidate)
goto need_revalidate;
>>>>> VvS: dentry was taken but requires revalidation
need_revalidate:
if (atomic)
return -EWOULDBLOCKIO;
>>>>> VvS: ... however if atomic is set, we forget to call dput before exit
Both problem come from the TUX patch. I wonder if someone actually use it. I do not know who uses TUX, but people will use O_CLOEXEC in new binaries. And it will lead to the troubles on filesystems where d_revalidate is implemented. Also It would be great to look at https://bugzilla.redhat.com/show_bug.cgi?id=315051 Yes sure. I wondered if we should get rid of TUX in the future. If it's not used, it's just a source of trouble. just a note that bug #315051: open(O_ATOMICLOOKUP) leaks dentry covers the leak problem for RHEL5. I'll close it as a duplicate of bug 358661. It is a private bug for some reason, but it says basically the same and it's already in POST status. It means a patch has been proposed and it is considered for 5.2. The patch simply removes all references to O_ATOMICLOOKUP from the kernel, because I found no users of it - not even the userspace part of tux used it. *** This bug has been marked as a duplicate of 358661 *** Quoting Don Zickus's comment from bug 358661: in 2.6.18-62.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 |