Bug 313681 - O_ATOMICLOOKUP vs O_CLOEXEC(mainstream kernels) incompatibility
Summary: O_ATOMICLOOKUP vs O_CLOEXEC(mainstream kernels) incompatibility
Status: CLOSED DUPLICATE of bug 358661
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.1
Hardware: All
OS: Linux
Target Milestone: ---
: ---
Assignee: Michal Schmidt
QA Contact: Martin Jenner
Depends On: 358661
TreeView+ depends on / blocked
Reported: 2007-10-01 10:58 UTC by Vasily Averin
Modified: 2008-01-09 17:51 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2007-12-05 13:58:52 UTC
Target Upstream Version:

Attachments (Terms of Use)

Description Vasily Averin 2007-10-01 10:58:26 UTC
O_ATOMICLOOKUP in RHEL4 and RHEL5 kernels uses the same flag number that
O_CLOEXEC flag in latest mainstream kernels

Comment 1 Vasily Averin 2007-10-01 13:04:31 UTC
btw I've found dentry leak in do_lookup():

static int do_lookup(struct nameidata *nd, struct qstr *name,
                     struct path *path, int atomic)
        struct vfsmount *mnt = nd->mnt;
        struct dentry *dentry = __d_lookup(nd->dentry, name);

        if (!dentry)
                goto need_lookup;
        if (dentry->d_op && dentry->d_op->d_revalidate)
                goto need_revalidate;
>>>>> VvS: dentry was taken but requires revalidation 

        if (atomic)
                return -EWOULDBLOCKIO;
>>>>> VvS: ... however if atomic is set, we forget to call dput before exit

Comment 2 Jerome Marchand 2007-10-05 07:38:36 UTC
Both problem come from the TUX patch. I wonder if someone actually use it.

Comment 3 Vasily Averin 2007-10-05 08:12:57 UTC
I do not know who uses TUX, but people will use O_CLOEXEC in new binaries. And
it  will lead to the troubles on filesystems where d_revalidate is implemented.

Also It would be great to look at 

Comment 4 Jerome Marchand 2007-10-05 09:01:24 UTC
Yes sure. I wondered if we should get rid of TUX in the future. If it's not
used, it's just a source of trouble.

Comment 5 Eric Sandeen 2007-10-30 16:47:06 UTC
just a note that bug #315051: open(O_ATOMICLOOKUP) leaks dentry covers the leak
problem for RHEL5.

Comment 6 Michal Schmidt 2007-12-05 13:58:52 UTC
I'll close it as a duplicate of bug 358661. It is a private bug for some reason,
but it says basically the same and it's already in POST status. It means a patch
has been proposed and it is considered for 5.2. The patch simply removes all
references to O_ATOMICLOOKUP from the kernel, because I found no users of it -
not even the userspace part of tux used it.

*** This bug has been marked as a duplicate of 358661 ***

Comment 7 Michal Schmidt 2008-01-09 17:51:53 UTC
Quoting Don Zickus's comment from bug 358661:

in 2.6.18-62.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Note You need to log in before you can comment on or make changes to this bug.