Red Hat Bugzilla – Bug 317691
orinoco driver sucks
Last modified: 2007-11-30 17:12:17 EST
As discussed here:
On Tue, Oct 02, 2007 at 07:59:10AM -0400, Dan Williams wrote:
> I think there's a lot of room for improvement in the driver. It's
> pretty racy with scan results. First, reading of scan results should be
> decoupled from the actual process of scanning, and scan results should
> be aged before being dropped completely. There's a fairly large window
> of time where scan results won't be available to the caller even though
> a successful scan could have happened a second ago. The scan_inprogress
> flag shouldn't have any semantics leak out to userspace.
Having this improved would make me really happy. Thanks!
Created attachment 220531 [details]
handle scan results better
Candidate patch; will send to linux-wireless
Matt; any chance you could test the patch out? If you'd rather get built
modules or a test kernel, I can poke linville to see if he can put one together.
I have a busy week, so I can test it today or tomorrow if I have a built module
or kernel; by the end of the week building it myself.
Dan, are there some orinoco.h bits missing from the patch? It seems to refer
to orinoco_private fields that don't exist...?
Created attachment 223851 [details]
(take 2) handle scan results better
include the orinoco.h bits this time
Rawhide-based test kernels building now:
Please post test results here...thanks!
Much, much better. I can switch back and forth between networks with nm-applet
with no trouble, and iwlist scan hasn't failed on me yet. Anything more in
specific I should test?
Yeah, can you revert back to the older driver/kernel and verify that the problem
is still present one more time before I send the final bits upstream?
Yeah, kernel-2.6.23-6.fc8 doesn't work.
Linville has queued this up for 2.6.25 FYI. Note that both airo and orinoco
will apparently only show the connected AP in scan results when they are locked
on a particular BSSID, which is what wpa_supplicant tells them to do. Not too
much we can do about that though. So after you're connected for a while, you'll
only see one AP in the scan list until you disconnect.
Might be nice, then, for nm-applet to have a "disconnect and rescan" menu
option. I suppose that's a different bug request. :)
This patch has been merged upstream. It should appear in
kernel-188.8.131.52-49.fc8 (or later) as well.