Spec URL: <http://rbhalera.fedorapeople.org/calmus-fonts/calmus-fonts.spec> SRPM URL: <http://rbhalera.fedorapeople.org/calmus-fonts/calmus-fonts-0.100-1.fc8.src.rpm> Description: The calmus-fonts package contains fonts for the display of Hebrew from the Culmus project. This package is being split from fonts-hebrew.
There are some updates Spec URL: <http://rbhalera.fedorapeople.org/culmus-fonts/culmus-fonts.spec> SRPM URL: <http://rbhalera.fedorapeople.org/culmus-fonts/culmus-fonts-0.101-1.fc8.src.rpm>
Created attachment 215681 [details] Modified SPEC. Attached is some more fonts packaging cleanups to SPEC
Spec URL: <http://rbhalera.fedorapeople.org/culmus-fonts/culmus-fonts.spec> SRPM URL: <http://rbhalera.fedorapeople.org/culmus-fonts/culmus-fonts-0.101-2.fc8.src.rpm>
thanks for updates. will do full review.
we don't need fonts.cache-1 file. Remove it and submit updated package.
Also, Source URL should be http://downloads.sourceforge.net/sourceforge/%{fontname}/%{fontname}-%{version}.tar.gz Remove Source1 as upstream tarball already provides LICENSE-BITSTREAM
Are we using full absolute source paths anywhere?
(In reply to comment #7) > Are we using full absolute source paths anywhere? Check http://fedoraproject.org/wiki/Packaging/SourceURL There you will find "For the Fedora packager, this means that sources used to build a package should be the vanilla sources available from upstream. To help reviewers and QA scripts verify this, the packager needs to indicate where a reviewer can find the source that was used to make the rpm." And if Red Hat is maintaining source as upstream then check http://fedoraproject.org/wiki/Packaging/SourceURL#head-413e1c297803cfa9de0cc4c56f3ac384bff5dc9e
Spec URL: <http://rbhalera.fedorapeople.org/culmus-fonts/culmus-fonts.spec> SRPM URL: <http://rbhalera.fedorapeople.org/culmus-fonts/culmus-fonts-0.101-3.fc8.src.rpm>
I think this package should have license GPLv2.
Yes, LICENSE says: "This package is distributed under the terms of GNU General Public License version 2 (see file GNU-GPL)." (the intention might have been GPLv2+ but that is not clearly stated).
update license to GPLv2. rest is ok.
Updated. Spec URL: <http://rbhalera.fedorapeople.org/culmus-fonts/culmus-fonts.spec> SRPM URL: <http://rbhalera.fedorapeople.org/culmus-fonts/culmus-fonts-0.101-4.fc8.src.rpm>
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 4dff942d859b9cac569d791c664e66a5 culmus-0.101.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + fonts scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI App. APPROVED.
New Package CVS Request ======================= Package Name: culmus-fonts Short Description: Fonts for Hebrew language from Culmus project Owners: rbhalera Branches: devel InitialCC: petersen Cvsextras Commits: yes
cvs done.