Spec URL: http://people.atrpms.net/~hdegoede/glaxium.spec SRPM URL: http://people.atrpms.net/~hdegoede/glaxium-0.5-1.fc8.src.rpm Description: Glaxium is an OpenGL-based space-ship "shoot-em-up" styled game. It is designed to provide the same feel as the old 2D games of that type, but with 3D for the special effects.
Review for release 1.fc7: * RPM name is OK * Source glaxium_0.5.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * rpmlint looks OK * File list looks OK * Works fine (38 checks have been run) Needs work: * Please install at least a 48x48 icon (required by the spec, see http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#install_icons) * Desktop file: the Icon tag should either use the full path to the icon or the icon name without extension (wiki:Packaging/Guidelines#desktop) Please fix these issues and you're good to go !
(In reply to comment #1) > Needs work: > * Please install at least a 48x48 icon (required by the spec, see > http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#install_icons) I've had this discussion before, not sure if it was with you though. The spec says: "Minimally you should install a 48x48 icon in the hicolor theme." Notice the *should*, the spec also describes in much more detail how a toolkit / application should search for icons. There it says that if an icon of the proper size isn't found all other possible sizes should be searched, and the icon should then be software scaled to the desired size. So installing a 128x128 icon will work fine, and scaling it to 48x48 is useless (more then that it would loose details when a bigger icon is wanted), as any toolkit / app following the spec will do the scaling itself if needed. > * Desktop file: the Icon tag should either use the full path to the icon or the > icon name without extension (wiki:Packaging/Guidelines#desktop) > Fixed. Here is a new version: Spec URL: http://people.atrpms.net/~hdegoede/glaxium.spec SRPM URL: http://people.atrpms.net/~hdegoede/glaxium-0.5-2.fc8.src.rpm
Fine by me. Review for release 2: * RPM name is OK * Source glaxium_0.5.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * rpmlint looks OK * File list looks OK * Works fine APPROVED
Thanks! New Package CVS Request ======================= Package Name: glaxium Short Description: An OpenGL space shooter Owners: jwrdegoede Branches: F-7 devel InitialCC: <empty> Cvsextras Commits: Yes
<ugh, I forgot to set the fedora cvs flag>
cvs done.
Imported and build, closing.