Red Hat Bugzilla – Bug 322781
Review Request: glpi - Free IT asset management software
Last modified: 2007-12-22 03:25:25 EST
Spec URL: http://remi.fedorapeople.org/glpi.spec SRPM URL: http://remi.fedorapeople.org/glpi-0.70-0.1.rc1.fc8.src.rpm Mock Log: http://remi.fedorapeople.org/glpi-build.log Description: GLPI is the Information Resource-Manager with an additional Administration- Interface. You can use it to build up a database with an inventory for your company (computer, software, printers...). It has enhanced functions to make the daily life for the administrators easier, like a job-tracking-system with mail-notification and methods to build a database with basic information about your network-topology. -- This is the Release Candidate of new 0.70 version. Database schema is freezed. I submit it to review. RC will be pushed to "testing", final version to "stable"
Notes : 1/ I work with upstream on this project 2/ I use this version in production (large inventory : more than 30.000 PC now, target is 90.000) 3/ Some "plugins" (among the >50 available) will also be proposed to review Remi.
Hello, A few remarks : - you should use macros or commands everywhere (mkdir or %{__mkdir}) - Source0 is not correct The package build successfully. rpmlint is not clean, assuming for a webapp, 'non-standard-uid' and 'non-standard-dir-perm' can safely be ignored. Also, rpmlint complains about a 'zero-lenght' file. Regards, Johan
Thanks for the comments. - editor_plugin.js (zero-lenght) is required in tiny_mce_gzip.js (intended for extension) - Source0 URL fixed - macros fixed Spec URL: http://remi.fedorapeople.org/glpi.spec SRPM URL: http://remi.fedorapeople.org/glpi-0.70-0.2.rc1.fc8.src.rpm
Review: + package builds in mock. + rpmlint is silent for SRPM and not RPMs but it is correct. + source file are ok. + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + BuildRequires are proper. + package installed properly. + Macro use appears rather consistent. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + package runs correctly. APPROVED.
New Package CVS Request ======================= Package Name: glpi Short Description: Free IT asset management software Owners: remi Branches: devel, F-7, FC-6, EL-5, EL-4 InitialCC: Cvsextras Commits: yes
cvs done.
glpi-0.70-0.2.rc1.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update glpi'