Bug 323111 - GFS1: security_eo_get() uses permission() when it should use security_inode_getxattr()
Summary: GFS1: security_eo_get() uses permission() when it should use security_inode_g...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: gfs-kmod
Version: 5.0
Hardware: All
OS: Linux
high
high
Target Milestone: rc
: ---
Assignee: Ryan O'Hara
QA Contact: GFS Bugs
URL:
Whiteboard:
Depends On: 307431
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-10-08 14:03 UTC by Steve Whitehouse
Modified: 2010-01-12 03:27 UTC (History)
5 users (show)

Fixed In Version: RHBA-2008-0348
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-05-21 15:37:16 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2008:0348 0 normal SHIPPED_LIVE gfs-kmod bug fix update 2008-05-20 12:47:43 UTC

Comment 1 Robert Peterson 2007-10-10 14:29:35 UTC 
Reassigning to Ryan Ohara because he now has bug #307431 and this is
really the same issue.
Comment 2 Ryan O'Hara 2007-12-04 19:33:08 UTC 
Fixed.

Removed calls to permission() from xattr ops. The permission() checks are
handled in the VFS layer, so there is no need for gfs to repeat this step.

Also note that checking permission() is incorrect for SELinux xattrs. The
correct permission check is done via the security_inode_getxattr(), etc. calls,
which are also done in the VFS layer.
Comment 3 Nate Straz 2007-12-19 20:03:47 UTC 
Planning on removing GFS-kernel.  Moving all bugs to gfs-kmod.
Comment 6 errata-xmlrpc 2008-05-21 15:37:16 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2008-0348.html
Note You need to log in before you can comment on or make changes to this bug.