Bug 327101 - Don't touch my curly braces!
Don't touch my curly braces!
Status: CLOSED UPSTREAM
Product: Fedora
Classification: Fedora
Component: eclipse-rpm-editor (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Alphonse Van Assche
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-10-10 20:31 EDT by Matěj Cepl
Modified: 2007-11-30 17:12 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-10-14 06:26:39 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
before (186.52 KB, image/png)
2007-10-12 05:53 EDT, Matěj Cepl
no flags Details
after (185.32 KB, image/png)
2007-10-12 05:53 EDT, Matěj Cepl
no flags Details

  None (edit)
Description Matěj Cepl 2007-10-10 20:31:30 EDT
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en; rv:1.8.1.6) Gecko/20070926 Epiphany/2.20 Firefox/2.0.0.6

Description of problem:
When writing

%{_lib

Eclipse suggests on Ctrl-<space> completion of %_libdir (note missing curly braces). Please, don't do that, the completion should be %{_libdir} (for example), because it apparently means something else than %_libdir.

Version-Release number of selected component (if applicable):
eclipse-rpm-editor-0.1.0-8.fc8

How reproducible:
Always


Steps to Reproduce:
1. write %{_lib
2. press Ctrl-SPACE

Actual Results:
%_libdir is suggested

Expected Results:
%{_libdir} should be suggested (note BOTH curly braces are suggested)

Additional info:
Comment 1 Alphonse Van Assche 2007-10-12 02:51:20 EDT
Hi Matej,

In this case the specfile editor suggest you %_libdir but when you press enter
the braces are added automatically. 

Do you prefer to type %_li Ctrl-Space and have the possibility to configure that
the braces are not added automatically? 
Comment 2 Matěj Cepl 2007-10-12 05:52:45 EDT
(In reply to comment #1)
> In this case the specfile editor suggest you %_libdir but when you press enter
> the braces are added automatically. 

I cannot confirm this. See the following two screenshots before and after
Ctrl-Space<Enter> -- I begin with %{_lib and ended with %libdir.
Comment 3 Matěj Cepl 2007-10-12 05:53:26 EDT
Created attachment 225321 [details]
before
Comment 4 Matěj Cepl 2007-10-12 05:53:50 EDT
Created attachment 225331 [details]
after
Comment 5 Alphonse Van Assche 2007-10-12 07:50:42 EDT
That's a bug, I will take a look on that this weekend.

Thanks for the feedback
Comment 6 Alphonse Van Assche 2007-10-14 06:26:39 EDT
Ok, I had accidentally add code that make the macro completion sucking.
Fixed in 0.1.0-10.

Note You need to log in before you can comment on or make changes to this bug.