+++ This bug was initially created as a clone of Bug #324111 +++ Spec URL: http://people.redhat.com/bnocera/python-gdata/python-gdata.spec SRPM URL: http://people.redhat.com/bnocera/python-gdata/python-gdata-1.0.8-1.src.rpm Description: This is a Python module for accessing online Google services, such as: - Blogger - Calendar - Picasa Web Albums - Spreadsheets - YouTube - Notebook
rpmlint gave me python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/apps/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/spreadsheet/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/docs/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/base/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/atom/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/docs/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/atom/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/calendar/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/spreadsheet/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/test_data.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/apps/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/base/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/calendar/service.py 0644 If this is of noarch type then do we still need following in SPEC ? %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")}
Good to add tests directory as %doc Also, are files under samples are also examples? If yes you can also add them to %doc. I think neither they are used in build nor they are installed. remember to run rpmlint on rpms before providing update.
(In reply to comment #1) > rpmlint gave me > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/apps/service.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/spreadsheet/service.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/docs/__init__.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/base/service.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/atom/__init__.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/__init__.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/docs/service.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/atom/service.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/calendar/__init__.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/spreadsheet/__init__.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/service.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/test_data.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/apps/__init__.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/base/__init__.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/calendar/service.py 0644 Those are completely bogus. We have #!/usr/bin/python up there, for use in the unit tests. They're not any useful for run-time. > If this is of noarch type then do we still need following in SPEC ? > %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print get_python_lib(1)")} Removed. (In reply to comment #2) > Good to add tests directory as %doc > Also, are files under samples are also examples? If yes you can also add them to > %doc. I think neither they are used in build nor they are installed. > > remember to run rpmlint on rpms before providing update. samples added, the tests are unit tests, that wouldn't be useful at all, unless you wanted to develop python-gdata. Updated: http://www.gnome.org/~hadess/python-gdata/python-gdata-1.0.8-2.fc8.src.rpm http://www.gnome.org/~hadess/python-gdata/python-gdata.spec
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM but not for RPM. python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/apps/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/spreadsheet/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/docs/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/base/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/atom/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/docs/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/atom/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/calendar/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/spreadsheet/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/test_data.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/apps/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/base/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/calendar/service.py 0644 ==> But these looks false messages. Ignored. + source files match upstream. b6f6aa192446047d8045d3c30345f1ef gdata.py-1.0.8.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED. SHOULD: Remove CFLAGS as this is python package and no compilations is happening that needs CFLAGS.
Thanks for the review! New Package CVS Request ======================= Package Name: python-gdata Short Description: A Python module for accessing online Google services Owners: hadess Branches: devel InitialCC: Cvsextras Commits: yes
cvs done.
(In reply to comment #6) > cvs done. Kevin, could you please create an F-8 branch as well? I created my request before the freeze... Package Change Request ====================== Package Name: python-gdata New Branches: F-8
python-gdata-1.0.8-3.fc9 built.
Done in F8 and devel. Thanks Kevin and Parag.
*** Bug 378441 has been marked as a duplicate of this bug. ***
Sorry, I somehow missed this submission when I submitted my package for review. Can you branch this back to F7 as well. Thanks.
(In reply to comment #12) > Sorry, I somehow missed this submission when I submitted my package for review. > Can you branch this back to F7 as well. Thanks. Please open a new bug with your login name, then you can DIY :)
http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure#head-529da50ad0b5cf0bedb9fdf47569c76657d79a7b "Please try to use the existing review ticket for these special requests, even if that ticket is CLOSED" I think as the package owner you should be requesting the branching??
(In reply to comment #14) > http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure#head-529da50ad0b5cf0bedb9fdf47569c76657d79a7b > > "Please try to use the existing review ticket for these special requests, even > if that ticket is CLOSED" Sigh. > I think as the package owner you should be requesting the branching?? I don't need python-gdata on F7, so please give me your username, and I'll add you to the maintainers so you do the builds/branching/whatever yourself. You'll probably need to update to 1.0.8 in F8 as well if you want the latest version in F7.
(In reply to comment #15) > I don't need python-gdata on F7, so please give me your username, and I'll add > you to the maintainers so you do the builds/branching/whatever yourself. You'll > probably need to update to 1.0.8 in F8 as well if you want the latest version in F7. Ok, I understand your response now :) FAS username: bjohnson Thanks
(In reply to comment #16) > Ok, I understand your response now :) > > FAS username: bjohnson Could you please add yourself to the commits and all, and I'll confirm those there: https://admin.fedoraproject.org/pkgdb/packages/name/python-gdata
(In reply to comment #15) > You'll probably need to update to 1.0.8 in F8 as well if you want the latest > version in F7. If it gets branched from devel (which I believe it will), I'll update F8 as well so that there is no EVR problems. Otherwise if it gets branched from an older version, I have no great need to have the latest. Package Change Request ====================== Package Name: python-gdata New Branches: F-7
new branches are created empty, ready for whatever you like to import... cvs done.
Package Change Request ====================== Package Name: python-gdata New Branches: EL-5 EL-6 Owners: agoode
Have you asked the fedora owner if they would like to maintain in EPEL?
Sorry, yes I did: https://bugzilla.redhat.com/show_bug.cgi?id=606479
CVS done. It does speed up the process if you tell us that you've received approval from the existing owner.