Matthias said he was willing to review this one.. it's a non-essential packager
and probably won't be in the default install for F8.

(In reply to comment #1)
> Matthias said he was willing to review this one.. it's a non-essential packager
> and probably won't be in the default install for F8.

Uh, I meant s/package/packager/ - no offense meant to Matthias! Sorry!

You don't need to set fedora-review? flag 
It should be set by reviewer.

1) Build.log showed me
checking for XML::Parser... configure: error: XML::Parser perl module is
required for intltool
=> You have missing BR: perl(XML::Parser)

2) missing ldconfig scriptlets

3)Now building again after adding missing BR, I saw
warning: File listed twice: /usr/share/gnome/help/gnome-device-manager/C
warning: File listed twice: /usr/share/gnome/help/gnome-device-manager/C/figures
warning: File listed twice:
/usr/share/gnome/help/gnome-device-manager/C/figures/gnome-device-manager.png
warning: File listed twice:
/usr/share/gnome/help/gnome-device-manager/C/gnome-device-manager.xml
warning: File listed twice: /usr/share/gnome/help/gnome-device-manager/C/legal.xml
warning: File listed twice:
/usr/share/omf/gnome-device-manager/gnome-device-manager-C.omf

4) you missed defattr(-,root,root,-) for -libs and -devel.
5)You may like to use make as
make %{?_smp_mflags}

Ok, I've done Parag and a few of my own cleanup to the spec, and I'll base the
review on that cleaned up spec/srpm, which I'll attach below.

rpmlint output:
rpmlint /var/lib/mock/fedora-development-i386/result/gnome-device-manager-*.i386.rpm
gnome-device-manager-devel.i386: W: no-documentation
gnome-device-manager-libs.i386: W: no-documentation

Package name: ok
spec file name: ok
packaging guidelines: followed
license: ok
license field: ok
license file: ok
spec language: american english
readability: excellent
upstream sources: ok
buildable: yes
ExcludeArch: n/a
BRs: ok
locales: handled properly
shared libs: ok
relocatable: n/a
directory ownership: ok
%files: ok
permissions: ok
%clean: ok
macro use: consistent
content: permissible
large docs: n/a
headers: ok
static libs: n/a
pc files: ok
shared libs: ok
devel package: ok
libtool archives: ok
directory ownership: ok
%install: ok
utf8 filenames: ok

Created attachment 230341 [details]
good spec

Approved

New Package CVS Request
=======================
Package Name: gnome-device-manager
Short Description: GNOME Device Manager is an application that provides a view of   
                   the various devices connected to the system.
Owners: davidz
Branches: 
InitialCC: 
Cvsextras Commits:

cvs done.

is this built?

hey, you can take over "nag davidz about this" from my daily todo...

still not built...

(In reply to comment #11)
> hey, you can take over "nag davidz about this" from my daily todo...
sorry?

> 
> still not built...

ok.

Built now