Red Hat Bugzilla – Bug 337801
Review Request: php-pear-pake - PHP5 project builder system
Last modified: 2007-11-30 17:12:18 EST
Spec URL: http://prelive.iconmobile.com/dev31/fedora-icm-repo/Fedora/7/SPECS/php-pear-pake.spec
SRPM URL: http://prelive.iconmobile.com/dev31/fedora-icm-repo/Fedora/7/SRPMS/php-pear-pake-1.1.4-2.fc7.src.rpm
pake is a PHP5 project build system with capabilities similar to make. pake has
the following features:
- pakefiles (pake’s version of Makefiles) are completely defined in standard
PHP5 syntax. No XML files to edit. No quirky Makefile syntax to worry about
(is that a tab or a space?)
- users can specify tasks with prerequisites
- pake is lightweight. It can be distributed with other projects as a single
file. Projects that depend upon pake do not require that pake be installed on
pake is heavily based on rake, a similar system for ruby.
One rpmlint issue:
php-pear-pake.noarch: W: file-not-utf8
Indeed, the license file contains a non-utf8 copyright symbol. A quick pass
through iconv fixes it up. Since it's minor and the only thing I can find to
quibble with, I'll go ahead and approve and you can fix it when you check in.
* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged (as far as I can tell; the upstream web site
seems a bit broken)
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
php-pear(pear.symfony-project.com/pake) = 1.1.4
php-pear-pake = 1.1.4-2.fc9
php-cli >= 5.0.1
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module registration)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
APPROVED, just pass the LICENSE file through iconv.
Thank you Jason, fixed that in -3.
New Package CVS Request
Package Name: php-pear-pake
Short Description: PHP5 project builder system
Branches: F-8 F-7
Cvsextras Commits: yes
All builds successful.