Bug 345611 - spew when machine doesn't support acpi
Summary: spew when machine doesn't support acpi
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: acpid
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Zdenek Prikryl
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F8Blocker
TreeView+ depends on / blocked
 
Reported: 2007-10-22 17:22 UTC by Jeremy Katz
Modified: 2007-11-30 22:12 UTC (History)
0 users

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2007-10-23 20:49:12 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jeremy Katz 2007-10-22 17:22:14 UTC
If running on a machine that doesn't support ACPI (such as qemu/kvm virtual
machines), the acpi initscript spews 
  /etc/init.d/acpid: need ACPI_PROC_EVENT support in kernel.  //zmena podle 260181
It should probably just silently not start if the /proc/acpi dir doesn't exist.

While cosmetic, this is highly visible with the Fedora 8 live images in
situations that are likely to be tried by reviewers, etc.

Comment 1 Zdenek Prikryl 2007-10-23 09:03:34 UTC
Hello,
I'm not sure, if it is good to do not print anything. Because if no message is
printed, then someone can assume that everything is fine. I think better
solution is print "Starting acpid daemon [failure]" and in /var/log/messages
have more info about a problem.

Zdenek

Comment 2 Jeremy Katz 2007-10-23 14:00:23 UTC
The normal behavior of many services is "hardware not present, initscript exits
early and silently".  

So basically very early in the initscript, just 
[ -d /proc/acpi ] || exit 0

Comment 4 Will Woods 2007-10-23 20:49:12 UTC
New build should show up in tomorrow's rawhide.


Note You need to log in before you can comment on or make changes to this bug.