Bug 34711 - fix RPM creation on IRIX
fix RPM creation on IRIX
Status: CLOSED RAWHIDE
Product: Red Hat Linux
Classification: Retired
Component: rpm (Show other bugs)
7.0
All Linux
medium Severity high
: ---
: ---
Assigned To: Jeff Johnson
David Lawrence
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2001-04-04 10:12 EDT by Joe Orton
Modified: 2007-04-18 12:32 EDT (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2001-04-04 10:13:26 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
First Fwrite fix (476 bytes, patch)
2001-04-04 10:12 EDT, Joe Orton
no flags Details | Diff
Second Fwrite fix (461 bytes, patch)
2001-04-04 10:13 EDT, Joe Orton
no flags Details | Diff

  None (edit)
Description Joe Orton 2001-04-04 10:12:00 EDT
Courtesy of IRIX cc: fix checking of Fwrite() return codes.

"pack.c", line 509: warning(1183): pointless comparison of unsigned integer
          with zero
  	if (Fwrite(buf, sizeof(buf[0]), count, fd) < 0) {

This is particularly nasty since the compiler *optimizes out* the call to
Fwrite(), producing .rpms which aren't really all there.

Patches coming up...
Comment 1 Joe Orton 2001-04-04 10:12:35 EDT
Created attachment 14623 [details]
First Fwrite fix
Comment 2 Joe Orton 2001-04-04 10:13:22 EDT
Created attachment 14624 [details]
Second Fwrite fix
Comment 3 Jeff Johnson 2001-04-17 14:29:28 EDT
Fixed in CVS, will be in rpm-4.0.3-0.5. Thanks for the patch.

Note You need to log in before you can comment on or make changes to this bug.