Bug 351611 - Review Request: perl-Object-Deadly - An object that dies whenever examined
Review Request: perl-Object-Deadly - An object that dies whenever examined
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-10-24 21:46 EDT by Robin Norwood
Modified: 2007-11-30 17:12 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-11-14 23:16:37 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Robin Norwood 2007-10-24 21:46:31 EDT
Spec URL: http://people.redhat.com/rnorwood/rpms/perl-Object-Deadly.spec
SRPM URL: http://people.redhat.com/rnorwood/rpms/perl-Object-Deadly-0.09-1.fc8.src.rpm
Description: Object::Deadly is meant to be used in testing. All possible
overloading and method calls die. You can pass this object into
methods which are not supposed to accidentally trigger any potentially
overloading.

Object::Deadly is used to test perl-Carp-Clan, and probably other modules.

See: https://bugzilla.redhat.com/show_bug.cgi?id=226244
Comment 1 Parag AN(पराग) 2007-10-24 23:00:06 EDT
make test failed tests.
Can you please look at that issues and add needed BRs to check make test is not
failing while building package?
Comment 3 Parag AN(पराग) 2007-10-26 01:51:18 EDT
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
fcf2895dd63b4bdd3a9ad683516b7aef  Object-Deadly-0.09.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs 
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/01pod.............skipped
        all skipped: Skipping author tests
t/02pod-coverage....skipped
        all skipped: Skipping author tests
t/03yaml............skipped
        all skipped: Skipping author tests
t/04boilerplate.....skipped
        all skipped: Skipping author tests
t/10load............# Testing Object::Deadly 0.09, Perl 5.008008, /usr/bin/perl
ok
t/20deadly..........ok
t/21class...........ok
All tests successful, 4 tests skipped.
Files=7, Tests=139,  1 wallclock secs ( 0.36 cusr +  0.06 csys =  0.42 CPU)
+ Package perl-Object-Deadly-0.09-2.fc8 ->
 Provides: perl(Object::Deadly) = 0.09 perl(Object::Deadly::_safe)
perl(Object::Deadly::_unsafe) Requires: perl(:MODULE_COMPAT_5.8.8) perl(B)
perl(Carp::Clan) >= 5.4 perl(Devel::Symdump) perl(English) perl(Object::Deadly)
perl(Object::Deadly::_safe) perl(Object::Deadly::_unsafe) perl(Scalar::Util)
perl(overload) perl(strict) perl(vars)

APPROVED.

                                                                               
     
Comment 4 Parag AN(पराग) 2007-11-13 03:51:43 EST
Robin,
 can you request for CVS and build this package?
Comment 5 Robin Norwood 2007-11-14 10:40:57 EST
New Package CVS Request
=======================
Package Name: perl-Object-Deadly
Short Description: An object that dies whenever examined
Owners: rnorwood@redhat.com
Branches: devel
InitialCC: fedora-perl-devel-list@redhat.com
Cvsextras Commits: yes
Comment 6 Kevin Fenzi 2007-11-14 19:29:27 EST
cvs done.
Comment 7 Robin Norwood 2007-11-14 23:16:37 EST
Build.  Closing.

Note You need to log in before you can comment on or make changes to this bug.