Bug 352581 - GFS2: implement gfs2_tool lockdump
Summary: GFS2: implement gfs2_tool lockdump
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: gfs2-utils   
(Show other bugs)
Version: 5.1
Hardware: All
OS: Linux
Target Milestone: ---
: ---
Assignee: Chris Feist
QA Contact: GFS Bugs
Depends On:
TreeView+ depends on / blocked
Reported: 2007-10-25 15:56 UTC by Robert Peterson
Modified: 2010-01-12 03:40 UTC (History)
0 users

Fixed In Version: RHBA-2008-0350
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-05-21 17:20:20 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Patch to implement gfs2_tool lockdump (3.72 KB, patch)
2007-11-07 00:05 UTC, Robert Peterson
no flags Details | Diff

External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2008:0350 normal SHIPPED_LIVE gfs2-utils bug fix update 2008-05-20 12:44:56 UTC

Description Robert Peterson 2007-10-25 15:56:21 UTC
Description of problem:
Long ago, we decided we needed to implement a function in GFS2
to replace the missing gfs2_tool lockdump.  We used bug #228540
to make the necessary changes to the gfs2 kernel code.  It makes
the glock information available to userland through the debugfs.

At that time, I implemented a userland patch to gfs2_tool that
used the new debugfs feature.  See comment #10 of bug 228540:

There was a comment in bugzilla stating that we should do the
userland portion of the fix, but apparently it was never done.
I thought I shipped the userland portion, but apparently not;
the code isn't there.  This is so that users don't have to mess
around with debugfs; gfs2_tool will do it for you.

The patch mentioned above isn't complete because the design of
228540 changed slightly.  The glock information in debugfs is now
one subdirectory level deeper I think.  Still, it should be a
cakewalk (< 1 hour) to implement, test and commit given the above
patch.  Well, maybe we should also make sure it has safeguards in
case debugfs isn't compiled into the kernel (which it always is in
RHEL, but not guaranteed in upstream) so call it 2 hours.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
gfs2_tool lockdump
Actual results:
gfs2_tool: lockdump not implemented

Expected results:
It should make use of the debugfs information.

Additional info:

Comment 1 Robert Peterson 2007-11-07 00:05:10 UTC
Created attachment 249781 [details]
Patch to implement gfs2_tool lockdump

I found several minor problems with the previously mentioned patch.
This version fixes all that up.  I've tested it thoroughly on roth-01.

Comment 2 Robert Peterson 2007-11-07 00:17:50 UTC
Requesting ack flags so we can get this into RHEL5.2.
Patch is in-hand and well tested.

Today the users can do the gfs2 glock dump simply by catting the
appropriate file in debugfs.  However, from past implementations, they
are used to doing "gfs_tool lockdump".  Therefore this implements that
feature which simply finds and dumps the file for them.  That makes
RHEL5 more user-friendly from their perspective.

Comment 3 RHEL Product and Program Management 2007-11-07 00:25:02 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update

Comment 4 Robert Peterson 2007-11-07 15:01:16 UTC
Fix tested on roth-01 and committed to CVS at HEAD and RHEL5 branches
for inclusion in RHEL5.2.  Changing status to modified.

Comment 7 errata-xmlrpc 2008-05-21 17:20:20 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.