Bug 355171 - Review Request: python-which - small GNU-which replacement
Summary: Review Request: python-which - small GNU-which replacement
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Patrice Dumas
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-10-27 12:53 UTC by Neal Becker
Modified: 2007-11-30 22:12 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-10-29 23:00:23 UTC
Type: ---
Embargoed:
pertusus: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Neal Becker 2007-10-27 12:53:42 UTC
Spec URL: https://nbecker/RPM/python-which.spec
SRPM URL: https://nbecker/RPM/python-which-1.1.0-1.fc8.noarch.rpm
Description: 
which.py is a small GNU-which replacement. It has the following features:

 * it can print all matches on the PATH;
 * it can note "near misses" on the PATH (e.g. files that match but 
   may not, say, have execute permissions); and
 * it can be used as a Python module.

NOTE: This is needed for dblatex which is in review

Comment 1 Neal Becker 2007-10-27 12:55:19 UTC
rpmlint says:
python-which.noarch: E: 
non-executable-script /usr/lib/python2.5/site-packages/which.py 0644

I think this is not an error.

Comment 2 Patrice Dumas 2007-10-27 20:09:26 UTC
The url is not the right one, and at the right one there is
no .src.rpm...

Comment 3 Neal Becker 2007-10-28 22:21:38 UTC
Sorry, make that:
https://nbecker/RPM/python-which-1.1.0-1.fc8.noarch.rpm
https://nbecker/RPM/python-which.spec(In reply to comment #2)
> The url is not the right one, and at the right one there is
> no .src.rpm...
Sorry, make that:
https://nbecker.dyndns.org/RPM/python-which-1.1.0-1.fc8.src.rpm
https://nbecker.dyndns.org/RPM/python-which.spec


Comment 4 Patrice Dumas 2007-10-28 23:07:43 UTC
* follow guidelines
* license MIT, license file included
* sane provides and requires
* rpmlint gives a warning because there is a shebang in 
  the module file. Not worth bothering.
python-which.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/which.py 0644
* %files section right
* match upstream
6f4abadf475af98e20664eac21f633a9  which-1.1.0.zip


APPROVED

Comment 5 Patrice Dumas 2007-10-28 23:10:34 UTC
Only one thing, I think that you should remove GNU 
in GNU-which, since there is no compatibility whith
GNu which, for instance not the same command line 
switches. 

Comment 6 Neal Becker 2007-10-29 01:10:53 UTC
New Package CVS Request
=======================
Package Name: python-which
Short Description: which.py is a small which replacement
Owners: ndbecker2
Branches: devel, F8
InitialCC: pertusus
Cvsextras Commits:

Comment 7 Toshio Ernie Kuratomi 2007-10-29 17:55:36 UTC
cvs done.

Comment 8 Neal Becker 2007-11-15 12:57:32 UTC
Package Change Request
======================
Package Name: python-which
New Branches: F-7 EL-5


Comment 9 Kevin Fenzi 2007-11-15 17:14:57 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.