Spec URL: http://tkmame.retrogames.com/fedora-extras/poker3d-data.spec SRPM URL: http://64.71.155.133/poker3d-data-1.1.36-1.fc7.src.rpm Description: Data files for the poker3d package.
I'll review this. Here are some MUST Fix and Should Fix from a first semi-thorough look: Must Fix: --------- * Source0 URL is invalid
One more remark: Must Fix: --------- * Must have a "Requires: poker3d >= %{version}", so that yum will remove the data when the users says "yum remove poker3d"
Spec URL: http://tkmame.retrogames.com/fedora-extras/poker3d-data.spec SRPM URL: http://64.71.155.133/poker3d-data-1.1.36-2.fc7.src.rpm %changelog * Tue Nov 06 2007 Christopher Stone <chris.stone> 1.1.36-2 - Fix Source0 URL - Add requires for poker3d package
I've done a full review, and I see no problems, except ... That I cannot find a reference to under which license the datafiles are available anywhere. I've tried upstreams website, etc. Can you either point me to some place where upstream declares this is GPL, or ask them by mail to confirm this is GPL?
There is a copyright file here: http://3dprod.pokersource.info/farms/poker3d-data/debian/copyright
Yeah, I already found that, but thats a bit vague / contains no clear link to the data files. Can you ask them to send you a mail in which they explicitly state that _all_ data files in the poker3d-data tar.gz are under the GPL? Then save that mail and add it as copyright.eml to %doc. Sorry to be a pita about this, but the current situation is just a bit to grey-ish to me.
Perhaps I can just add http://3dprod.pokersource.info/farms/poker3d-data/debian/copyright to the %doc of the package. I'm not sure if the GPL'd version has been officially released or if we need to wait for an official release. I've asked Loic to respond to this bug.
All files in the package are under the GNU/GPL, yes.
(In reply to comment #8) > All files in the package are under the GNU/GPL, yes. OK thats good enough for me, APPROVED!
New Package CVS Request ======================= Package Name: poker3d-data Short Description: Data files for the poker3d package Owners: xulchris Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
oops, I think we will have time to go ahead and make an FC-6 build as well. Adding FC-6 branch to request: New Package CVS Request ======================= Package Name: poker3d-data Short Description: Data files for the poker3d package Owners: xulchris Branches: FC-6 F-7 F-8 InitialCC: Cvsextras Commits: yes
Sorry. FC-6 branches are no longer allowed (as of the release of F-8). :( Otherwise, cvs done.
Build successful, thanks for the review! http://koji.fedoraproject.org/koji/taskinfo?taskID=245307
*** Bug 515188 has been marked as a duplicate of this bug. ***